From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200])
	by kanga.kvack.org (Postfix) with ESMTP id 555C16B0033
	for <linux-mm@kvack.org>; Mon,  2 Oct 2017 10:29:52 -0400 (EDT)
Received: by mail-qk0-f200.google.com with SMTP id w63so4723000qkd.0
        for <linux-mm@kvack.org>; Mon, 02 Oct 2017 07:29:52 -0700 (PDT)
Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28])
        by mx.google.com with ESMTPS id r6si4637147qkb.318.2017.10.02.07.29.51
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Mon, 02 Oct 2017 07:29:51 -0700 (PDT)
Date: Mon, 2 Oct 2017 17:29:47 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC] [PATCH] mm,oom: Offload OOM notify callback to a kernel
 thread.
Message-ID: <20171002172349-mutt-send-email-mst@kernel.org>
References: <20170929065654-mutt-send-email-mst@kernel.org>
 <201709291344.FID60965.VHtMQFFJFSLOOO@I-love.SAKURA.ne.jp>
 <201710011444.IBD05725.VJSFHOOMOFtLQF@I-love.SAKURA.ne.jp>
 <20171002065801-mutt-send-email-mst@kernel.org>
 <20171002090627.547gkmzvutrsamex@dhcp22.suse.cz>
 <201710022033.GFE82801.HLOVOFFJtSFQMO@I-love.SAKURA.ne.jp>
 <20171002115035.7sph6ul6hsszdwa4@dhcp22.suse.cz>
 <20171002170642-mutt-send-email-mst@kernel.org>
 <20171002141900.acmcbilwhqethfhq@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171002141900.acmcbilwhqethfhq@dhcp22.suse.cz>
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, jasowang@redhat.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, paulmck@linux.vnet.ibm.com, josh@joshtriplett.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, virtualization@lists.linux-foundation.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org

On Mon, Oct 02, 2017 at 04:19:00PM +0200, Michal Hocko wrote:
> On Mon 02-10-17 17:11:55, Michael S. Tsirkin wrote:
> > On Mon, Oct 02, 2017 at 01:50:35PM +0200, Michal Hocko wrote:
> [...]
> > > and some
> > > other call path is allocating while holding the lock. But you seem to be
> > > right and
> > > leak_balloon
> > >   tell_host
> > >     virtqueue_add_outbuf
> > >       virtqueue_add
> > > 
> > > can do GFP_KERNEL allocation and this is clearly wrong. Nobody should
> > > try to allocate while we are in the OOM path. Michael, is there any way
> > > to drop this?
> > 
> > Yes - in practice it won't ever allocate - that path is never taken
> > with add_outbuf - it is for add_sgs only.
> > 
> > IMHO the issue is balloon inflation which needs to allocate
> > memory. It does it under a mutex, and oom handler tries to take the
> > same mutex.
> 
> try_lock for the oom notifier path should heal the problem then, righ?
> At least for as a quick fix.

IMHO it definitely fixes the deadlock. But it does not fix the bug
that balloon isn't sometimes deflated on oom even though the deflate on
oom flag is set.

> -- 
> Michal Hocko
> SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC] [PATCH] mm,
 oom: Offload OOM notify callback to a kernel thread.
Date: Mon, 2 Oct 2017 17:29:47 +0300
Message-ID: <20171002172349-mutt-send-email-mst@kernel.org>
References: <20170929065654-mutt-send-email-mst@kernel.org>
 <201709291344.FID60965.VHtMQFFJFSLOOO@I-love.SAKURA.ne.jp>
 <201710011444.IBD05725.VJSFHOOMOFtLQF@I-love.SAKURA.ne.jp>
 <20171002065801-mutt-send-email-mst@kernel.org>
 <20171002090627.547gkmzvutrsamex@dhcp22.suse.cz>
 <201710022033.GFE82801.HLOVOFFJtSFQMO@I-love.SAKURA.ne.jp>
 <20171002115035.7sph6ul6hsszdwa4@dhcp22.suse.cz>
 <20171002170642-mutt-send-email-mst@kernel.org>
 <20171002141900.acmcbilwhqethfhq@dhcp22.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6B3266E33B
 for <intel-gfx@lists.freedesktop.org>; Mon,  2 Oct 2017 14:29:51 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20171002141900.acmcbilwhqethfhq@dhcp22.suse.cz>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, jasowang@redhat.com, jiangshanlai@gmail.com, josh@joshtriplett.org, virtualization@lists.linux-foundation.org, airlied@linux.ie, mathieu.desnoyers@efficios.com, rostedt@goodmis.org, rodrigo.vivi@intel.com, paulmck@linux.vnet.ibm.com, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBPY3QgMDIsIDIwMTcgYXQgMDQ6MTk6MDBQTSArMDIwMCwgTWljaGFsIEhvY2tvIHdy
b3RlOgo+IE9uIE1vbiAwMi0xMC0xNyAxNzoxMTo1NSwgTWljaGFlbCBTLiBUc2lya2luIHdyb3Rl
Ogo+ID4gT24gTW9uLCBPY3QgMDIsIDIwMTcgYXQgMDE6NTA6MzVQTSArMDIwMCwgTWljaGFsIEhv
Y2tvIHdyb3RlOgo+IFsuLi5dCj4gPiA+IGFuZCBzb21lCj4gPiA+IG90aGVyIGNhbGwgcGF0aCBp
cyBhbGxvY2F0aW5nIHdoaWxlIGhvbGRpbmcgdGhlIGxvY2suIEJ1dCB5b3Ugc2VlbSB0byBiZQo+
ID4gPiByaWdodCBhbmQKPiA+ID4gbGVha19iYWxsb29uCj4gPiA+ICAgdGVsbF9ob3N0Cj4gPiA+
ICAgICB2aXJ0cXVldWVfYWRkX291dGJ1Zgo+ID4gPiAgICAgICB2aXJ0cXVldWVfYWRkCj4gPiA+
IAo+ID4gPiBjYW4gZG8gR0ZQX0tFUk5FTCBhbGxvY2F0aW9uIGFuZCB0aGlzIGlzIGNsZWFybHkg
d3JvbmcuIE5vYm9keSBzaG91bGQKPiA+ID4gdHJ5IHRvIGFsbG9jYXRlIHdoaWxlIHdlIGFyZSBp
biB0aGUgT09NIHBhdGguIE1pY2hhZWwsIGlzIHRoZXJlIGFueSB3YXkKPiA+ID4gdG8gZHJvcCB0
aGlzPwo+ID4gCj4gPiBZZXMgLSBpbiBwcmFjdGljZSBpdCB3b24ndCBldmVyIGFsbG9jYXRlIC0g
dGhhdCBwYXRoIGlzIG5ldmVyIHRha2VuCj4gPiB3aXRoIGFkZF9vdXRidWYgLSBpdCBpcyBmb3Ig
YWRkX3NncyBvbmx5Lgo+ID4gCj4gPiBJTUhPIHRoZSBpc3N1ZSBpcyBiYWxsb29uIGluZmxhdGlv
biB3aGljaCBuZWVkcyB0byBhbGxvY2F0ZQo+ID4gbWVtb3J5LiBJdCBkb2VzIGl0IHVuZGVyIGEg
bXV0ZXgsIGFuZCBvb20gaGFuZGxlciB0cmllcyB0byB0YWtlIHRoZQo+ID4gc2FtZSBtdXRleC4K
PiAKPiB0cnlfbG9jayBmb3IgdGhlIG9vbSBub3RpZmllciBwYXRoIHNob3VsZCBoZWFsIHRoZSBw
cm9ibGVtIHRoZW4sIHJpZ2g/Cj4gQXQgbGVhc3QgZm9yIGFzIGEgcXVpY2sgZml4LgoKSU1ITyBp
dCBkZWZpbml0ZWx5IGZpeGVzIHRoZSBkZWFkbG9jay4gQnV0IGl0IGRvZXMgbm90IGZpeCB0aGUg
YnVnCnRoYXQgYmFsbG9vbiBpc24ndCBzb21ldGltZXMgZGVmbGF0ZWQgb24gb29tIGV2ZW4gdGhv
dWdoIHRoZSBkZWZsYXRlIG9uCm9vbSBmbGFnIGlzIHNldC4KCj4gLS0gCj4gTWljaGFsIEhvY2tv
Cj4gU1VTRSBMYWJzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm
eAo=