From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbdJBUen (ORCPT ); Mon, 2 Oct 2017 16:34:43 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:52574 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbdJBUel (ORCPT ); Mon, 2 Oct 2017 16:34:41 -0400 Date: Mon, 2 Oct 2017 16:34:23 -0400 From: Johannes Weiner To: Shakeel Butt Cc: Michal Hocko , Tim Hockin , Roman Gushchin , Tejun Heo , kernel-team@fb.com, David Rientjes , Linux MM , Vladimir Davydov , Tetsuo Handa , Andrew Morton , Cgroups , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [v8 0/4] cgroup-aware OOM killer Message-ID: <20171002203423.GA19849@cmpxchg.org> References: <20170927162300.GA5623@castle.DHCP.thefacebook.com> <20171002122434.llbaarb6yw3o3mx3@dhcp22.suse.cz> <20171002192814.sad75tqklp3nmr4m@dhcp22.suse.cz> <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 02, 2017 at 01:24:25PM -0700, Shakeel Butt wrote: > On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko wrote: > > On Mon 02-10-17 12:45:18, Shakeel Butt wrote: > >> > I am sorry to cut the rest of your proposal because it simply goes over > >> > the scope of the proposed solution while the usecase you are mentioning > >> > is still possible. If we want to compare intermediate nodes (which seems > >> > to be the case) then we can always provide a knob to opt-in - be it your > >> > oom_gang or others. > >> > >> In the Roman's proposed solution we can already force the comparison > >> of intermediate nodes using 'oom_group', I am just requesting to > >> separate the killall semantics from it. > > > > oom_group _is_ about killall semantic. And comparing killable entities > > is just a natural thing to do. So I am not sure what you mean > > > > I am saying decouple the notion of comparable entities and killable entities. Feel free to send patches in a new thread. We don't need this level of control for this series to be useful - to us, and other users. It can easily be added on top of Roman's work. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [v8 0/4] cgroup-aware OOM killer Date: Mon, 2 Oct 2017 16:34:23 -0400 Message-ID: <20171002203423.GA19849@cmpxchg.org> References: <20170927162300.GA5623@castle.DHCP.thefacebook.com> <20171002122434.llbaarb6yw3o3mx3@dhcp22.suse.cz> <20171002192814.sad75tqklp3nmr4m@dhcp22.suse.cz> <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=82oHuLKNqTmiYSMynyDXNsLurPYZEbQfC/um3cr5eN8=; b=q/y57H2HUvpxXv9/Ei80nf+TyQ xlY6xipJvJJkYd0Manb3f51+fu62mf1iQdh7Aju+OBTmYKFatguGCAy+pz88M1BtAW0KUUXfmNjH5 VDZ51DRbiC136SbHhAwnHnT1LFGKLA4Vfos5lgdby6dWPi//+bO5AMxGm78AmkIktXJk=; Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shakeel Butt Cc: Michal Hocko , Tim Hockin , Roman Gushchin , Tejun Heo , kernel-team@fb.com, David Rientjes , Linux MM , Vladimir Davydov , Tetsuo Handa , Andrew Morton , Cgroups , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" On Mon, Oct 02, 2017 at 01:24:25PM -0700, Shakeel Butt wrote: > On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko wrote: > > On Mon 02-10-17 12:45:18, Shakeel Butt wrote: > >> > I am sorry to cut the rest of your proposal because it simply goes over > >> > the scope of the proposed solution while the usecase you are mentioning > >> > is still possible. If we want to compare intermediate nodes (which seems > >> > to be the case) then we can always provide a knob to opt-in - be it your > >> > oom_gang or others. > >> > >> In the Roman's proposed solution we can already force the comparison > >> of intermediate nodes using 'oom_group', I am just requesting to > >> separate the killall semantics from it. > > > > oom_group _is_ about killall semantic. And comparing killable entities > > is just a natural thing to do. So I am not sure what you mean > > > > I am saying decouple the notion of comparable entities and killable entities. Feel free to send patches in a new thread. We don't need this level of control for this series to be useful - to us, and other users. It can easily be added on top of Roman's work. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org