From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbdJCXMo (ORCPT ); Tue, 3 Oct 2017 19:12:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:49276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbdJCXMn (ORCPT ); Tue, 3 Oct 2017 19:12:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7725214E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 3 Oct 2017 19:12:40 -0400 From: Steven Rostedt To: Jan Kiszka Cc: Linux Kernel Mailing List Subject: Re: [PATCH][trace-cmd] Print value of unknown symbolic fields Message-ID: <20171003191240.692c21e7@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Sep 2017 22:13:10 +0200 Jan Kiszka wrote: > From: Jan Kiszka > > Aligns trace-cmd with the behavior of the kernel. > > Signed-off-by: Jan Kiszka > --- > event-parse.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/event-parse.c b/event-parse.c > index 606da5b..25e0874 100644 > --- a/event-parse.c > +++ b/event-parse.c > @@ -3960,6 +3960,8 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, > break; > } > } > + if (!flag) > + trace_seq_printf(s, "0x%llx", val); > break; > case PRINT_HEX: > if (arg->hex.field->type == PRINT_DYNAMIC_ARRAY) { I'm going to also add this patch, to do the same for flags: diff --git a/event-parse.c b/event-parse.c index 25e0874..7ef66f8 100644 --- a/event-parse.c +++ b/event-parse.c @@ -3950,6 +3950,11 @@ static void print_str_arg(struct trace_seq *s, void *data, int size, val &= ~fval; } } + if (val) { + if (print && arg->flags.delim) + trace_seq_puts(s, arg->flags.delim); + trace_seq_printf(s, "0x%llx", val); + } break; case PRINT_SYMBOL: val = eval_num_arg(data, size, event, arg->symbol.field); -- Steve