From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:50254 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdJDACS (ORCPT ); Tue, 3 Oct 2017 20:02:18 -0400 Date: Tue, 3 Oct 2017 17:02:09 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 03/25] xfs: probe the scrub ioctl Message-ID: <20171004000209.GG6503@magnolia> References: <150706324963.19351.17715069858921948692.stgit@magnolia> <150706326848.19351.10670988265979551239.stgit@magnolia> <20171003233247.GQ3666@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171003233247.GQ3666@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: linux-xfs@vger.kernel.org On Wed, Oct 04, 2017 at 10:32:47AM +1100, Dave Chinner wrote: > On Tue, Oct 03, 2017 at 01:41:08PM -0700, Darrick J. Wong wrote: > > +/* > > + * Scrub probe -- userspace uses this to probe if we're willing to > > + * scrub or repair a given mountpoint. > > + */ > > +int > > +xfs_scrub_probe( > > + struct xfs_scrub_context *sc) > > +{ > > + if (sc->sm->sm_ino || sc->sm->sm_agno) > > + return -EINVAL; > > + if (sc->sm->sm_gen & ~XFS_SCRUB_FLAGS_OUT) > > sm_flags? sm_gen is correct because in xfs_scrub_probe we reflect back to userspace any valid scrub outflags that were passed in via sm_gen. Therefore we have to check sm_gen for unknown output flags so that we can error out on any invalid inputs from userland. xfs_scrub_metadata() unconditionally clears all the out flags from sm_flags on its way in, prior to any of the scrub handlers being called. (It's possible I'm misunderstanding your question.) --D > > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html