All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Alan Cox <alan@llwyncelyn.cymru>, Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com
Subject: Re: tty crash due to auto-failing vmalloc
Date: Wed, 4 Oct 2017 10:33:43 +0200	[thread overview]
Message-ID: <20171004083343.tqy5xjzyd332bwdn@dhcp22.suse.cz> (raw)
In-Reply-To: <20171003225504.GA966@cmpxchg.org>

On Tue 03-10-17 18:55:04, Johannes Weiner wrote:
[...]
> commit 5d17a73a2ebeb8d1c6924b91e53ab2650fe86ffb
> Author: Michal Hocko <mhocko@suse.com>
> Date:   Fri Feb 24 14:58:53 2017 -0800
> 
>     vmalloc: back off when the current task is killed
>     
>     __vmalloc_area_node() allocates pages to cover the requested vmalloc
>     size.  This can be a lot of memory.  If the current task is killed by
>     the OOM killer, and thus has an unlimited access to memory reserves, it
>     can consume all the memory theoretically.  Fix this by checking for
>     fatal_signal_pending and back off early.
>     
>     Link: http://lkml.kernel.org/r/20170201092706.9966-4-mhocko@kernel.org
>     Signed-off-by: Michal Hocko <mhocko@suse.com>
>     Reviewed-by: Christoph Hellwig <hch@lst.de>
>     Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>     Cc: Al Viro <viro@zeniv.linux.org.uk>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> This talks about the oom killer and memory exhaustion, but most fatal
> signals don't happen due to the OOM killer.

Now that we have cd04ae1e2dc8 ("mm, oom: do not rely on TIF_MEMDIE for
memory reserves access") the risk of the memory depletion is much
smaller so reverting the above commit should be acceptable. On the other
hand the failure is still possible and the caller should be prepared for
that.
-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Alan Cox <alan@llwyncelyn.cymru>, Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com
Subject: Re: tty crash due to auto-failing vmalloc
Date: Wed, 4 Oct 2017 10:33:43 +0200	[thread overview]
Message-ID: <20171004083343.tqy5xjzyd332bwdn@dhcp22.suse.cz> (raw)
In-Reply-To: <20171003225504.GA966@cmpxchg.org>

On Tue 03-10-17 18:55:04, Johannes Weiner wrote:
[...]
> commit 5d17a73a2ebeb8d1c6924b91e53ab2650fe86ffb
> Author: Michal Hocko <mhocko@suse.com>
> Date:   Fri Feb 24 14:58:53 2017 -0800
> 
>     vmalloc: back off when the current task is killed
>     
>     __vmalloc_area_node() allocates pages to cover the requested vmalloc
>     size.  This can be a lot of memory.  If the current task is killed by
>     the OOM killer, and thus has an unlimited access to memory reserves, it
>     can consume all the memory theoretically.  Fix this by checking for
>     fatal_signal_pending and back off early.
>     
>     Link: http://lkml.kernel.org/r/20170201092706.9966-4-mhocko@kernel.org
>     Signed-off-by: Michal Hocko <mhocko@suse.com>
>     Reviewed-by: Christoph Hellwig <hch@lst.de>
>     Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>     Cc: Al Viro <viro@zeniv.linux.org.uk>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> This talks about the oom killer and memory exhaustion, but most fatal
> signals don't happen due to the OOM killer.

Now that we have cd04ae1e2dc8 ("mm, oom: do not rely on TIF_MEMDIE for
memory reserves access") the risk of the memory depletion is much
smaller so reverting the above commit should be acceptable. On the other
hand the failure is still possible and the caller should be prepared for
that.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-10-04  8:33 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 22:55 tty crash due to auto-failing vmalloc Johannes Weiner
2017-10-03 22:55 ` Johannes Weiner
2017-10-03 23:51 ` Alan Cox
2017-10-03 23:51   ` Alan Cox
2017-10-04  8:33 ` Michal Hocko [this message]
2017-10-04  8:33   ` Michal Hocko
2017-10-04 18:58 ` Johannes Weiner
2017-10-04 18:58   ` Johannes Weiner
2017-10-04 18:59   ` [PATCH 1/2] Revert "vmalloc: back off when the current task is killed" Johannes Weiner
2017-10-04 18:59     ` Johannes Weiner
2017-10-04 20:49     ` Tetsuo Handa
2017-10-04 20:49       ` Tetsuo Handa
2017-10-04 21:00       ` Johannes Weiner
2017-10-04 21:00         ` Johannes Weiner
2017-10-04 21:42         ` Tetsuo Handa
2017-10-04 21:42           ` Tetsuo Handa
2017-10-04 23:21           ` Johannes Weiner
2017-10-04 23:21             ` Johannes Weiner
2017-10-04 22:32     ` Andrew Morton
2017-10-04 22:32       ` Andrew Morton
2017-10-04 23:18       ` Johannes Weiner
2017-10-04 23:18         ` Johannes Weiner
2017-10-05  7:57         ` Michal Hocko
2017-10-05  7:57           ` Michal Hocko
2017-10-05 10:36           ` Tetsuo Handa
2017-10-05 10:36             ` Tetsuo Handa
2017-10-05 10:49             ` Michal Hocko
2017-10-05 10:49               ` Michal Hocko
2017-10-07  2:21             ` Tetsuo Handa
2017-10-07  2:21               ` Tetsuo Handa
2017-10-07  2:51               ` Johannes Weiner
2017-10-07  2:51                 ` Johannes Weiner
2017-10-07  4:05                 ` Tetsuo Handa
2017-10-07  4:05                   ` Tetsuo Handa
2017-10-07  7:59                   ` Michal Hocko
2017-10-07  7:59                     ` Michal Hocko
2017-10-07  9:57                     ` Tetsuo Handa
2017-10-07  9:57                       ` Tetsuo Handa
2017-10-05  6:49     ` Vlastimil Babka
2017-10-05  6:49       ` Vlastimil Babka
2017-10-05  7:54     ` Michal Hocko
2017-10-05  7:54       ` Michal Hocko
2017-10-04 18:59   ` [PATCH 2/2] tty: fall back to N_NULL if switching to N_TTY fails during hangup Johannes Weiner
2017-10-04 18:59     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004083343.tqy5xjzyd332bwdn@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@llwyncelyn.cymru \
    --cc=hannes@cmpxchg.org \
    --cc=hch@lst.de \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.