From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c Date: Wed, 4 Oct 2017 16:21:25 -0700 Message-ID: <20171004232125.GC457@codeaurora.org> References: <20171003091155.7138-1-linus.walleij@linaro.org> <20171003091155.7138-2-linus.walleij@linaro.org> <20171004220923.GB457@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51986 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdJDXV1 (ORCPT ); Wed, 4 Oct 2017 19:21:27 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Rob Clark Cc: Nicolas Dechesne , Srinivas Kandagatla , Linus Walleij , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm , Andy Gross , David Brown , Bjorn Andersson , linux-soc@vger.kernel.org, Alexander Graf On 10/04, Rob Clark wrote: > On Wed, Oct 4, 2017 at 6:09 PM, Stephen Boyd wrote: > > On 10/04, Rob Clark wrote: > >> If we managed to get this in before the 4.14 LTS I might feel > >> differently. But afterwards, totally not. :-( > >> > > > > How do you install dtbs onto your device? Should be simple enough > > to run 'mv' on the new filename to the old one? > > > > it is part of the kernel package Are you copying the file out of the arch/arm64/boot/dts directory? Or you're using dtbs_install rule? > but fixing it in the distro means fixing it in *every* distro.. That assumes every distro has a bootloader that's looking for one file name vs. the other. And that the distro hasn't updated the bootloader to pick a different name. > > if we are going for a workaround, then it should be the kernel > installing a symlink. Not every distro having to fix things up in the > same way for one particular board. There was a discussion about this years ago when the dtbs_install rule was introduced to the kernel makefiles[1]. Maybe the sentiment has changed, but it seems that people involved in that thread didn't consider the filename an ABI. Also, take a look at commit f4d4ffc03efc ("kbuild: dtbs_install: new make target") where it says: "Removed option to call external script. Copying the files should be sufficient and a build system can post-process the install directory. Despite the fact an external script is used for installing the kernel, I don't think that is a pattern that should be encouraged. I would rather see buildroot type tools post process the install directory to rename or move dtb files after installing to a staging directory." which makes it look like the distro installation scripts would rename things if desired. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-November/210562.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Wed, 4 Oct 2017 16:21:25 -0700 Subject: [PATCH 2/2] arm64: dts: qcom: Rename SBC to DragonBoard 410c In-Reply-To: References: <20171003091155.7138-1-linus.walleij@linaro.org> <20171003091155.7138-2-linus.walleij@linaro.org> <20171004220923.GB457@codeaurora.org> Message-ID: <20171004232125.GC457@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/04, Rob Clark wrote: > On Wed, Oct 4, 2017 at 6:09 PM, Stephen Boyd wrote: > > On 10/04, Rob Clark wrote: > >> If we managed to get this in before the 4.14 LTS I might feel > >> differently. But afterwards, totally not. :-( > >> > > > > How do you install dtbs onto your device? Should be simple enough > > to run 'mv' on the new filename to the old one? > > > > it is part of the kernel package Are you copying the file out of the arch/arm64/boot/dts directory? Or you're using dtbs_install rule? > but fixing it in the distro means fixing it in *every* distro.. That assumes every distro has a bootloader that's looking for one file name vs. the other. And that the distro hasn't updated the bootloader to pick a different name. > > if we are going for a workaround, then it should be the kernel > installing a symlink. Not every distro having to fix things up in the > same way for one particular board. There was a discussion about this years ago when the dtbs_install rule was introduced to the kernel makefiles[1]. Maybe the sentiment has changed, but it seems that people involved in that thread didn't consider the filename an ABI. Also, take a look at commit f4d4ffc03efc ("kbuild: dtbs_install: new make target") where it says: "Removed option to call external script. Copying the files should be sufficient and a build system can post-process the install directory. Despite the fact an external script is used for installing the kernel, I don't think that is a pattern that should be encouraged. I would rather see buildroot type tools post process the install directory to rename or move dtb files after installing to a staging directory." which makes it look like the distro installation scripts would rename things if desired. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-November/210562.html -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project