From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Thu, 05 Oct 2017 10:02:53 +0000 Subject: Re: [PATCH] mm, arch: remove empty_bad_page* Message-Id: <20171005100253.GD31821@linux-mips.org> List-Id: References: <20171004150045.30755-1-mhocko@kernel.org> In-Reply-To: <20171004150045.30755-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: Andrew Morton , LKML , Michal Hocko , David Howells , Ingo Molnar , Jeff Dike , linux-mips@linux-mips.org, linux-sh@vger.kernel.org, Richard Weinberger , Rich Felker , uclinux-h8-devel@lists.sourceforge.jp, Yoshinori Sato On Wed, Oct 04, 2017 at 05:00:45PM +0200, Michal Hocko wrote: > From: Michal Hocko > > empty_bad_page and empty_bad_pte_table seems to be a relict from old > days which is not used by any code for a long time. I have tried to find > when exactly but this is not really all that straightforward due to many > code movements - traces disappear around 2.4 times. > > Anyway no code really references neither empty_bad_page nor > empty_bad_pte_table. We only allocate the storage which is not used by > anybody so remove them. > > Cc: Yoshinori Sato > Cc: Ralf Baechle > Cc: David Howells > Cc: Rich Felker > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Ingo Molnar > Cc: > Cc: > Cc: > Signed-off-by: Michal Hocko On MIPS the empty_bad_page_table definition was deleted in 2549fa57708d ("Small cleanups including deletion of two variables 4k each ...") in the MIPS git tree on 2003-07-29, so Acked-by: Ralf Baechle for getting rid of the rest a mere 14 years later. Thanks, Ralf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751514AbdJEKDI (ORCPT ); Thu, 5 Oct 2017 06:03:08 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:34654 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdJEKDG (ORCPT ); Thu, 5 Oct 2017 06:03:06 -0400 Date: Thu, 5 Oct 2017 12:02:53 +0200 From: Ralf Baechle To: Michal Hocko Cc: Andrew Morton , LKML , Michal Hocko , David Howells , Ingo Molnar , Jeff Dike , linux-mips@linux-mips.org, linux-sh@vger.kernel.org, Richard Weinberger , Rich Felker , uclinux-h8-devel@lists.sourceforge.jp, Yoshinori Sato Subject: Re: [PATCH] mm, arch: remove empty_bad_page* Message-ID: <20171005100253.GD31821@linux-mips.org> References: <20171004150045.30755-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171004150045.30755-1-mhocko@kernel.org> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 04, 2017 at 05:00:45PM +0200, Michal Hocko wrote: > From: Michal Hocko > > empty_bad_page and empty_bad_pte_table seems to be a relict from old > days which is not used by any code for a long time. I have tried to find > when exactly but this is not really all that straightforward due to many > code movements - traces disappear around 2.4 times. > > Anyway no code really references neither empty_bad_page nor > empty_bad_pte_table. We only allocate the storage which is not used by > anybody so remove them. > > Cc: Yoshinori Sato > Cc: Ralf Baechle > Cc: David Howells > Cc: Rich Felker > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Ingo Molnar > Cc: > Cc: > Cc: > Signed-off-by: Michal Hocko On MIPS the empty_bad_page_table definition was deleted in 2549fa57708d ("Small cleanups including deletion of two variables 4k each ...") in the MIPS git tree on 2003-07-29, so Acked-by: Ralf Baechle for getting rid of the rest a mere 14 years later. Thanks, Ralf