All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brendan Jackman <brendan.jackman@arm.com>
To: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH RESEND v3 0/5]
Date: Thu,  5 Oct 2017 12:45:11 +0100	[thread overview]
Message-ID: <20171005114516.18617-1-brendan.jackman@arm.com> (raw)

This patchset optimises away an unused comparison, and fixes some corner cases in
the find_idlest_group path of select_task_rq_fair.

Changes v2 -> v3:

 - 1/5 through 4/5 unchanged.

 - 5/5: Essentially undid [1]. Vincent pointed out that this isn't really a
   bugfix but more of a change in policy. Now find_idlest_group still returns
   NULL when the local group is idlest.

   I previously said some extra code could be removed in this case, but after
   more careful inspection I changed my mind.

Changes v1 -> v2:

 - Reworked task affinity checks to avoid repeating them, as per Vincent's
   suggestion. To avoid excessive indentation this required moving code into its
   own function, as per PeterZ's suggestion.

 - Split up the patches.

[1]
 - Altered the caller of find_idlest_group so that it now unconditionally uses
   find_idlest_group_cpu (formerly find_idlest_cpu). This means that we more
   often use the maligned "perspective-switching" logic at the bottom of the
   while(sd) loop, but it also means the task placement algorithm is more
   consistent between whether the idlest group is local or remote.

   As mentioned in 5/5 an alternative would be to just initialise @new_cpu to
   @cpu instead of @prev_cpu (which is what PeterZ suggested in v1 review). In
   that case, some extra code could be removed in & around
   find_idlest_group_cpu.

Brendan Jackman (5):
  sched/fair: Move select_task_rq_fair slow-path into its own function
  sched/fair: Remove unnecessary comparison with -1
  sched/fair: Fix find_idlest_group when local group is not allowed
  sched/fair: Fix use of find_idlest_group when no groups are allowed
  sched/fair: Fix use of find_idlest_group when local group is idlest

 kernel/sched/fair.c | 93 ++++++++++++++++++++++++++++++++---------------------
 1 file changed, 56 insertions(+), 37 deletions(-)

-- 
2.14.1

             reply	other threads:[~2017-10-05 11:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 11:45 Brendan Jackman [this message]
2017-10-05 11:45 ` [PATCH RESEND v3 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Brendan Jackman
2017-10-10 10:59   ` [tip:sched/core] sched/fair: Move select_task_rq_fair() " tip-bot for Brendan Jackman
2017-10-05 11:45 ` [PATCH RESEND v3 2/5] sched/fair: Remove unnecessary comparison with -1 Brendan Jackman
2017-10-10 10:59   ` [tip:sched/core] " tip-bot for Brendan Jackman
2017-10-05 11:45 ` [PATCH RESEND v3 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Brendan Jackman
2017-10-10 11:00   ` [tip:sched/core] sched/fair: Fix find_idlest_group() " tip-bot for Brendan Jackman
2017-10-05 11:45 ` [PATCH RESEND v3 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Brendan Jackman
2017-10-10 11:00   ` [tip:sched/core] sched/fair: Fix usage of find_idlest_group() " tip-bot for Brendan Jackman
2017-10-05 11:45 ` [PATCH RESEND v3 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest Brendan Jackman
2017-10-10 11:01   ` [tip:sched/core] sched/fair: Fix usage of find_idlest_group() when the " tip-bot for Brendan Jackman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005114516.18617-1-brendan.jackman@arm.com \
    --to=brendan.jackman@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.