All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PULL 8/9] qom: update doc comment for type_register[_static]()
Date: Thu,  5 Oct 2017 17:36:37 -0300	[thread overview]
Message-ID: <20171005203638.19255-9-ehabkost@redhat.com> (raw)
In-Reply-To: <20171005203638.19255-1-ehabkost@redhat.com>

From: Igor Mammedov <imammedo@redhat.com>

type_register()/type_register_static() functions in current impl.
can't fail returning 0, also none of the users check for error
so update doc comment to reflect current behaviour.

Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1507111682-66171-2-git-send-email-imammedo@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 include/qom/object.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qom/object.h b/include/qom/object.h
index e0d9824415..a707b67781 100644
--- a/include/qom/object.h
+++ b/include/qom/object.h
@@ -773,7 +773,7 @@ const char *object_get_typename(const Object *obj);
  * @info and all of the strings it points to should exist for the life time
  * that the type is registered.
  *
- * Returns: 0 on failure, the new #Type on success.
+ * Returns: the new #Type.
  */
 Type type_register_static(const TypeInfo *info);
 
@@ -784,7 +784,7 @@ Type type_register_static(const TypeInfo *info);
  * Unlike type_register_static(), this call does not require @info or its
  * string members to continue to exist after the call returns.
  *
- * Returns: 0 on failure, the new #Type on success.
+ * Returns: the new #Type.
  */
 Type type_register(const TypeInfo *info);
 
-- 
2.13.6

  parent reply	other threads:[~2017-10-05 20:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-05 20:36 [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05 Eduardo Habkost
2017-10-05 20:36 ` [Qemu-devel] [PULL 1/9] hw/acpi-build: Make assignment statement of next_base easy to read Eduardo Habkost
2017-11-28 15:07   ` Igor Mammedov
2017-11-29  1:07     ` Dou Liyang
2017-10-05 20:36 ` [Qemu-devel] [PULL 2/9] ACPI/unit-test: Add a new testcase for RAM allocation in numa node Eduardo Habkost
2017-11-28 15:08   ` Igor Mammedov
2017-11-29  1:06     ` Dou Liyang
2017-10-05 20:36 ` [Qemu-devel] [PULL 3/9] qom/cpu: move cpu_model null check to cpu_class_by_name() Eduardo Habkost
2017-10-05 20:36 ` [Qemu-devel] [PULL 4/9] machine: Add a valid_cpu_types property Eduardo Habkost
2017-10-05 20:36 ` [Qemu-devel] [PULL 5/9] vl: Eliminate defconfig variable Eduardo Habkost
2017-10-05 20:36 ` [Qemu-devel] [PULL 6/9] qemu-options: Deprecate -nodefconfig Eduardo Habkost
2017-10-05 20:36 ` [Qemu-devel] [PULL 7/9] config: qemu_config_parse() return number of config groups Eduardo Habkost
2017-10-05 20:36 ` Eduardo Habkost [this message]
2017-10-05 20:36 ` [Qemu-devel] [PULL 9/9] x86: Correct translation of some rdgsbase and wrgsbase encodings Eduardo Habkost
2017-10-06 12:17 ` [Qemu-devel] [PULL 0/9] x86 and machine queue, 2017-10-05 Peter Maydell
2017-10-06 13:45   ` Thomas Huth
2017-10-06 15:27   ` Eduardo Habkost
2017-10-06 15:37     ` Peter Maydell
2017-10-10  7:41       ` Dou Liyang
2017-10-10  9:40         ` Peter Maydell
2017-10-10 13:29           ` Dou Liyang
2017-10-10 12:52         ` Eduardo Habkost
2017-10-10 12:56           ` Peter Maydell
2017-10-10 14:17             ` Dou Liyang
2017-10-10 16:03             ` Eduardo Habkost
2017-10-10 13:07           ` Dou Liyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171005203638.19255-9-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.