From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH v2 1/4] crypto/mrvl: add mrvl crypto pmd
	driver
Date: Fri, 6 Oct 2017 09:05:24 +0200
Message-ID: <20171006070524.GB11828@tdu>
References: <1506418805-12117-1-git-send-email-tdu@semihalf.com>
 <1506594212-15803-1-git-send-email-tdu@semihalf.com>
 <1506594212-15803-2-git-send-email-tdu@semihalf.com>
 <20171005154736.GA23608@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, mw@semihalf.com,
 dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@linaro.org,
 Jacek Siuda <jck@semihalf.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com
 [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 116101B24E
 for <dev@dpdk.org>; Fri,  6 Oct 2017 09:05:26 +0200 (CEST)
Received: by mail-lf0-f49.google.com with SMTP id l23so12453005lfk.10
 for <dev@dpdk.org>; Fri, 06 Oct 2017 00:05:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20171005154736.GA23608@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 05, 2017 at 04:47:37PM +0100, Bruce Richardson wrote:
> On Thu, Sep 28, 2017 at 12:23:29PM +0200, Tomasz Duszynski wrote:
> > Add support for the Marvell Security Crypto Accelerator EIP197.
> > Driver is based on external, publicly available, Marvell MUSDK
> > library that provides access to the hardware with minimum overhead
> > and high performance.
> >
> > Driver comes with support for the following features:
> >
> > * Symmetric crypto
> > * Sym operation chaining
> > * AES CBC (128)
> > * AES CBC (192)
> > * AES CBC (256)
> > * AES CTR (128)
> > * AES CTR (192)
> > * AES CTR (256)
> > * 3DES CBC
> > * 3DES CTR
> > * MD5
> > * MD5 HMAC
> > * SHA1
> > * SHA1 HMAC
> > * SHA256
> > * SHA256 HMAC
> > * SHA384
> > * SHA384 HMAC
> > * SHA512
> > * SHA512 HMAC
> > * AES GCM (128)
> >
> > Driver was engineered cooperatively by Semihalf and Marvell teams.
> >
> > Semihalf:
> > Jacek Siuda <jck@semihalf.com>
> > Tomasz Duszynski <tdu@semihalf.com>
> >
> > Marvell:
> > Dmitri Epshtein <dima@marvell.com>
> > Natalie Samsonov <nsamsono@marvell.com>
> >
> > Signed-off-by: Jacek Siuda <jck@semihalf.com>
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > ---
> >  config/common_base                           |   6 +
> >  drivers/crypto/Makefile                      |   2 +
> >  drivers/crypto/mrvl/Makefile                 |  63 ++
> >  drivers/crypto/mrvl/rte_mrvl_compat.h        |  48 ++
> >  drivers/crypto/mrvl/rte_mrvl_pmd.c           | 870 +++++++++++++++++++=
++++++++
> >  drivers/crypto/mrvl/rte_mrvl_pmd_ops.c       | 787 +++++++++++++++++++=
+++++
> >  drivers/crypto/mrvl/rte_mrvl_pmd_private.h   | 121 ++++
> >  drivers/crypto/mrvl/rte_mrvl_pmd_version.map |   3 +
>
> The standard convention for naming version files for these drivers is
> "rte_pmd_<name>_version.map". Without this, the new meson build system
> will have trouble finding the map file. The same convention applies to
> net drivers too.
>

OK. Thanks for pointing this out.

> Regards,
> /Bruce

--
- Tomasz Duszy=C5=84ski