Re: [PATCH for-4.10 1/5] tools/dombuilder: Drop more PVH v1 leftovers

[Wei Liu <wei.liu2@citrix.com>]

On Fri, Oct 06, 2017 at 10:26:03AM +0100, Roger Pau Monné wrote:
> On Thu, Oct 05, 2017 at 06:23:39PM +0000, Andrew Cooper wrote:
> > alloc_magic_pages() is renamed to alloc_magic_pages_pv() to mirror its
> > alloc_magic_pages_hvm() counterpart.  Delete a redundant comment, introduce
> > some newlines clarity, and remove a logically dead allocation of shared info.
> > 
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> > ---
> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Julien Grall <julien.grall@arm.com>
> > ---
> >  tools/libxc/xc_dom_x86.c | 16 ++++++----------
> >  1 file changed, 6 insertions(+), 10 deletions(-)
> > 
> > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> > index cb68efc..885ca1b 100644
> > --- a/tools/libxc/xc_dom_x86.c
> > +++ b/tools/libxc/xc_dom_x86.c
> > @@ -534,24 +534,20 @@ static int alloc_p2m_list_x86_64(struct xc_dom_image *dom)
> >  
> >  /* ------------------------------------------------------------------------ */
> >  
> > -static int alloc_magic_pages(struct xc_dom_image *dom)
> > +static int alloc_magic_pages_pv(struct xc_dom_image *dom)
> >  {
> > -    /* allocate special pages */
> >      dom->start_info_pfn = xc_dom_alloc_page(dom, "start info");
> >      if ( dom->start_info_pfn == INVALID_PFN )
> >          return -1;
> 
> Maybe those errors paths should set errno = ENOMEM?

I believe the actual allocation function already does that.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel