From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v6 0/5] increase port_id range Date: Fri, 6 Oct 2017 15:31:23 +0200 Message-ID: <20171006133123.GA31685@bidouze.vm.6wind.com> References: <20170925032231.72897-1-zhiyong.yang@intel.com> <20170929071727.21618-1-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Zhiyong Yang , dev@dpdk.org, thomas@monjalon.net, Nelio Laranjeiro , Declan Doherty To: Ferruh Yigit Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 8AA571B1BA for ; Fri, 6 Oct 2017 15:32:28 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id i124so7954106wmf.3 for ; Fri, 06 Oct 2017 06:32:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 06, 2017 at 03:15:40AM +0100, Ferruh Yigit wrote: > On 9/29/2017 8:17 AM, Zhiyong Yang wrote: > > port_id is currently defined as uint8_t, which is limited to the range > > 0 to 255. A larger range is required for vdev scalability. > > > > It is necessary for a redefinition of port_id to extend it from > > 1 bytes to 2 bytes. All ethdev APIs and usages related to port_id will > > be changed at the same time. > > > > Discussion about port_id is the following thread. > > http://www.dpdk.org/dev/patchwork/patch/23208/ > > > > Changes in V2: > > 1. cover more PMDs to increase port_id range. > > 2. cover more examples to increase port_id range. > > 3. add 17.11 release note. > > > > Changes in V3: > > 1. cover mlx4 and mlx5. > > 2. add to increase port_id range in test code. > > 3. The patch "librte_mbuf: modify port initialization value" is merged > > into the patchset. > > > > Changes in V4: > > 1. Add a patch to remove bonding APIs using ABI versioning according to > > Ferruh's comments. > > 2. Unify to use typedef portid_t in testpmd code. > > 3. update release note deprecation doc in 2/5 > > 4. fix some issues according to comments. > > > > Changes in V5: > > 1. For 1/5, bond_mode_8023ad_conf_get_v1708() and bond_mode_8023ad_conf > > _get() are merged into one function bond_mode_8023ad_conf_get. > > > > Changes in V6: > > 1. For 2/5, remove the unnecessary LIBABIVER in Makefile and update > > the release notes "Shared Library Versions". > > Note: The patchset have dependency on the following patch. > > http://www.dpdk.org/dev/patchwork/patch/28738/ > > http://www.dpdk.org/dev/patchwork/patch/29219/ > > > > Note: 3/5 and 4/5 patches' building depends on 2/5 patch since 2/5 patch > > breaks lib/PMD API/ABI. > > > > Zhiyong Yang (5): > > net/bonding: remove bonding APIs using ABI versioning > > ethdev: increase port_id range > > examples: increase port_id range > > test: increase port_id range > > librte_mbuf: modify port initialization value > > Series applied to dpdk-next-net/master, thanks. > > There was merge conflict for: > rte_eth_bond_pmd.c > failsafe_private.h > mlx5_rxtx.h > > Maintainers of these files cc'ed, can you please double check latest > files in next-net? Hello Ferruh, The only potential conflicts I see are on the event callbacks 8<----- int failsafe_eth_rmv_event_callback(uint16_t port_id, enum rte_eth_event_type type, void *arg, void *out); int failsafe_eth_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type event, void *cb_arg, void *out); ----->8 and I see no issue there on next-net. Let me know if you want me to check something specific. Regards, -- Gaëtan Rivet 6WIND