All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 0/6] Fix 32-bit cross compilation
Date: Fri, 6 Oct 2017 16:43:20 +0200	[thread overview]
Message-ID: <20171006144320.vqrg4i2bte7beklv@x230> (raw)
In-Reply-To: <874lrc4mrc.fsf@our.domain.is.not.set>

Hi Richard,

thanks a lot for a feadback.
> > these patches fixes 32-bit cross compilation build.
> > I'm not an autotools expert so I tried to minimize changes.
> > I extended header checks with library checks.

> Good stuff, I have briefly tested the patch and it seems to
> work. However I am wondering whether it is a good idea to remove the
> header checks. It is not clear to me that AC_CHECK_LIB also somehow
> checks that the relevant header exists as well. Perhaps it guesses the
> header path from the library name, but it doesn't quite make sense to
> me.
No, it an error, AC_CHECK_LIB doesn't check it. I'll put the relevant checks back in v2,
into AC_CHECK_HEADERS in configure.ac.


Kind regards,
Petr

      reply	other threads:[~2017-10-06 14:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06  1:53 [LTP] [RFC PATCH 0/6] Fix 32-bit cross compilation Petr Vorel
2017-10-06  1:53 ` [LTP] [RFC PATCH 1/6] m4: Fix libkeyutils detection on 32-bit cross build Petr Vorel
2017-10-06  1:53 ` [LTP] [RFC PATCH 2/6] m4: Fix libacl " Petr Vorel
2017-10-06  1:53 ` [LTP] [RFC PATCH 3/6] m4: Simplify check for linux/can.h header Petr Vorel
2017-10-06  1:53 ` [LTP] [RFC PATCH 4/6] m4: Fix libcrypto detection on 32-bit cross build Petr Vorel
2017-10-06  1:53 ` [LTP] [RFC PATCH 5/6] make: Remove workarounds for build without libnuma Petr Vorel
2017-10-06  1:53 ` [LTP] [RFC PATCH 6/6] m4, kernel/lib: Detect libnuma presence in kernel libs Petr Vorel
2017-10-06 10:02 ` [LTP] [RFC PATCH 0/6] Fix 32-bit cross compilation Richard Palethorpe
2017-10-06 14:43   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006144320.vqrg4i2bte7beklv@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.