From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752097AbdJFOy7 (ORCPT ); Fri, 6 Oct 2017 10:54:59 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:44921 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdJFOy6 (ORCPT ); Fri, 6 Oct 2017 10:54:58 -0400 Date: Fri, 6 Oct 2017 07:54:50 -0700 From: Matthew Wilcox To: Olivier Galibert Cc: Adam Borowski , Al Viro , linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] vfs: hard-ban creating files with control characters in the name Message-ID: <20171006145450.GA18373@bombadil.infradead.org> References: <20171003005042.16470-1-kilobyte@angband.pl> <20171003020724.GH21978@ZenIV.linux.org.uk> <20171003032203.6ufi7cmsgu47mrke@angband.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 05, 2017 at 12:07:57PM +0200, Olivier Galibert wrote: > On Tue, Oct 3, 2017 at 5:22 AM, Adam Borowski wrote: > > Well, what about just \n then? Unlike all the others which are relatively > > straightforward, \n requires -print0 which not all programs implement, and > > way too many people consider too burdensome to use. > > If you don't use -print0, you're vulnerable to spaces. Go on, try to > disallow spaces in file names, I'll pass the popcorn. The David Wheeler argument for this is to change IFS to "\n\t" from " \n\t". Personally, I think it's easier to use -print0.