All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] fs: btrfs: Fix printf length modifier
Date: Fri, 6 Oct 2017 15:14:53 +0200	[thread overview]
Message-ID: <20171006151453.1247e2fd@dellmb.labs.office.nic.cz> (raw)
In-Reply-To: <20171006130459.29127-3-marek.behun@nic.cz>

Hmm, this is weird. Tom's commit 6b7fd350

http://git.denx.de/?p=u-boot.git;a=commit;h=6b7fd350e85a97892a2cb066364797f3f3dcb9c9

forces %lu here, because the %u issued a warning.
But my compiler warns when %lu is used.
Maybe we should use PRIu32 instead...

...

On Fri,  6 Oct 2017 15:04:58 +0200
Marek Behún <marek.behun@nic.cz> wrote:

> Change %lu to %u. The compiler issues a warning otherwise.
> 
> Signed-off-by: Marek Behun <marek.behun@nic.cz>
> ---
>  fs/btrfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 2529c2b3b6..706286ee2d 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -147,7 +147,7 @@ static int btrfs_check_super(struct
> btrfs_super_block *sb) 
>  	if (sb->sys_chunk_array_size < sizeof(struct btrfs_key) +
>  	    sizeof(struct btrfs_chunk)) {
> -		printf("%s: system chunk array too small %u <
> %lu\n", __func__,
> +		printf("%s: system chunk array too small %u < %u\n",
> __func__, sb->sys_chunk_array_size, (u32) sizeof(struct btrfs_key)
>  		       + sizeof(struct btrfs_chunk));
>  		ret = -1;

  reply	other threads:[~2017-10-06 13:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 13:04 [U-Boot] [PATCH 1/4] linux/time.h: Remove dead code Marek Behún
2017-10-06 13:04 ` [U-Boot] [PATCH 2/4] fs: btrfs: Fix usage of uninitialized variables Marek Behún
     [not found]   ` <99f56d19-544c-4604-4f82-bd7a9a1e45b6@comcast.net>
2017-10-06 14:28     ` Marek Behún
2017-10-17  0:47   ` [U-Boot] [U-Boot, " Tom Rini
2017-10-06 13:04 ` [U-Boot] [PATCH 3/4] fs: btrfs: Fix printf length modifier Marek Behún
2017-10-06 13:14   ` Marek Behún [this message]
2017-10-06 14:23     ` Tom Rini
2017-10-06 13:04 ` [U-Boot] [PATCH 4/4] fs: btrfs: Remove a foreign language note Marek Behún
2017-10-17  0:47   ` [U-Boot] [U-Boot, " Tom Rini
2017-10-17  0:47 ` [U-Boot] [U-Boot,1/4] linux/time.h: Remove dead code Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006151453.1247e2fd@dellmb.labs.office.nic.cz \
    --to=marek.behun@nic.cz \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.