All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Daudt <me@ikke.info>
To: Alexander Gehrke <alexander.gehrke@qwertyuiop.de>
Cc: git@vger.kernel.org
Subject: Re: [bug] git add -p breaks, if color.ui is set to "always"
Date: Fri, 6 Oct 2017 17:42:39 +0200	[thread overview]
Message-ID: <20171006154239.GA9299@alpha.vpn.ikke.info> (raw)
In-Reply-To: <20171006124730.onetucvpt3btlali@wheatley.informatik.uni-wuerzburg.de>

On Fri, Oct 06, 2017 at 02:47:30PM +0200, Alexander Gehrke wrote:
> After an update to version 2.14.2 from 2.14.1 "git add --patch" stopped working
> for me, just producing the same output as "git diff", but not prompting to stage
> anything.
> 
> I found that unsetting the config key color.ui, which was set to "always" fixed
> the problem.
> 
> From the manpage, color.ui should not have that effect and "always" should be a
> legal value.
> 
> Regards
> Alexander Gehrke

Hello Alexander,

There have been a few mailing-list posts[0] about this already. While
git add -p should probably not have broken by this, setting ui.color to
always itself does not make a lot of sense either.

You are telling git to always output color, even when the target is
something that does not know what to do with the color codes. Setting it
to 'auto' would make more sense.

The thread I posted to discusses some changes that might get introduced
to improve the situation though.

Kevin.

[0}:https://public-inbox.org/git/20171003093157.gq7za2fwcqsouire@sigill.intra.peff.net/T/

      reply	other threads:[~2017-10-06 15:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 12:47 [bug] git add -p breaks, if color.ui is set to "always" Alexander Gehrke
2017-10-06 15:42 ` Kevin Daudt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006154239.GA9299@alpha.vpn.ikke.info \
    --to=me@ikke.info \
    --cc=alexander.gehrke@qwertyuiop.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.