From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752433AbdJFRfk (ORCPT ); Fri, 6 Oct 2017 13:35:40 -0400 Received: from verein.lst.de ([213.95.11.211]:33965 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751766AbdJFRfj (ORCPT ); Fri, 6 Oct 2017 13:35:39 -0400 Date: Fri, 6 Oct 2017 19:35:38 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: "Michael S . Tsirkin" , linux-kernel@vger.kernel.org, Christoph Hellwig , Linus Torvalds Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Message-ID: <20171006173538.GA4106@lst.de> References: <20171006172353.16758-1-bart.vanassche@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171006172353.16758-1-bart.vanassche@wdc.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote: > The purpose of patch "linux/types.h: enable endian checks for all > sparse builds" was to encourage driver authors to annotate > endianness correctly in their drivers. However, since that patch > went upstream no endianness annotations in drivers have been fixed. > I think that this shows that the followed approach does not work, > probably because several driver authors do not use sparse. Restore > the ability to disable sparse endianness checks such that it > becomes again easy to review other sparse diagnostics for people > who want to analyze drivers they are not the author of. So how do we get people to do it? Out of the sparse checks endianess warnings are the most useful, together with __user and __iomem.