All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>,
	Mike Marciniszyn
	<infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 41/47] IB/qib: Suppress gcc 7 fall-through complaints
Date: Fri,  6 Oct 2017 14:33:27 -0700	[thread overview]
Message-ID: <20171006213333.6721-42-bart.vanassche@wdc.com> (raw)
In-Reply-To: <20171006213333.6721-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>

Avoid that gcc 7 reports the following warning when building with W=1:

warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Bart Van Assche <bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
Cc: Mike Marciniszyn <infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/qib/qib_mad.c  | 1 +
 drivers/infiniband/hw/qib/qib_rc.c   | 2 +-
 drivers/infiniband/hw/qib/qib_sdma.c | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index 1237952c144e..04367e0f6f9b 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -434,6 +434,7 @@ static int check_mkey(struct qib_ibport *ibp, struct ib_smp *smp, int mad_flags)
 			/* Bad mkey not a violation below level 2 */
 			if (ibp->rvp.mkeyprot < 2)
 				break;
+			/* fall through */
 		case IB_MGMT_METHOD_SET:
 		case IB_MGMT_METHOD_TRAP_REPRESS:
 			if (ibp->rvp.mkey_violations != 0xFFFF)
diff --git a/drivers/infiniband/hw/qib/qib_rc.c b/drivers/infiniband/hw/qib/qib_rc.c
index e9a91736b12d..8f5754fb8579 100644
--- a/drivers/infiniband/hw/qib/qib_rc.c
+++ b/drivers/infiniband/hw/qib/qib_rc.c
@@ -1869,7 +1869,7 @@ void qib_rc_rcv(struct qib_ctxtdata *rcd, struct ib_header *hdr,
 		qp->r_rcv_len = 0;
 		if (opcode == OP(SEND_ONLY))
 			goto no_immediate_data;
-		/* FALLTHROUGH for SEND_ONLY_WITH_IMMEDIATE */
+		/* fall through -- for SEND_ONLY_WITH_IMMEDIATE */
 	case OP(SEND_LAST_WITH_IMMEDIATE):
 send_last_imm:
 		wc.ex.imm_data = ohdr->u.imm_data;
diff --git a/drivers/infiniband/hw/qib/qib_sdma.c b/drivers/infiniband/hw/qib/qib_sdma.c
index 891873b38a1e..c3690bd51582 100644
--- a/drivers/infiniband/hw/qib/qib_sdma.c
+++ b/drivers/infiniband/hw/qib/qib_sdma.c
@@ -808,7 +808,7 @@ void __qib_sdma_process_event(struct qib_pportdata *ppd,
 			 * bringing the link up with traffic active on
 			 * 7220, e.g. */
 			ss->go_s99_running = 1;
-			/* fall through and start dma engine */
+			/* fall through -- and start dma engine */
 		case qib_sdma_event_e10_go_hw_start:
 			/* This reference means the state machine is started */
 			sdma_get(&ppd->sdma_state);
-- 
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-10-06 21:33 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 21:32 [PATCH 00/47] Address issues detected by static analysis tools Bart Van Assche
     [not found] ` <20171006213333.6721-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 21:32   ` [PATCH 01/47] IB/core: Fix endianness annotation in rdma_is_multicast_addr() Bart Van Assche
     [not found]     ` <20171006213333.6721-2-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:50       ` Leon Romanovsky
2017-10-06 21:32   ` [PATCH 02/47] IB/cm: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-3-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:03       ` Hefty, Sean
2017-10-10 19:27       ` Dennis Dalessandro
     [not found]         ` <849d304a-fa89-0d6a-6edb-cf34780e41a8-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-10 19:29           ` Hefty, Sean
2017-10-10 19:31           ` Leon Romanovsky
     [not found]             ` <20171010193127.GK2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 19:49               ` Dennis Dalessandro
2017-10-06 21:32   ` [PATCH 03/47] RDMA/cma: Avoid triggering undefined behavior Bart Van Assche
     [not found]     ` <20171006213333.6721-4-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:01       ` Hefty, Sean
2017-10-06 21:32   ` [PATCH 04/47] RDMA/iwcm: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <20171006213333.6721-5-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:05       ` Steve Wise
2017-10-06 21:32   ` [PATCH 05/47] RDMA/uverbs: Make the code in ib_uverbs_cmd_verbs() less confusing Bart Van Assche
     [not found]     ` <20171006213333.6721-6-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09  7:40       ` Matan Barak (External)
     [not found]         ` <64b5f415-7d56-3f17-0c8c-5d80ba89582c-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-09 17:27           ` Bart Van Assche
     [not found]             ` <1507570048.2674.17.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-11  5:19               ` Matan Barak
     [not found]                 ` <3a6adf24-3e60-7fd1-a119-37586793d374-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-10-11 15:30                   ` Bart Van Assche
     [not found]                     ` <1507735840.2477.8.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-15  7:37                       ` Matan Barak
2017-10-06 21:32   ` [PATCH 06/47] RDMA/isert: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-7-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:10       ` Sagi Grimberg
2017-10-06 21:32   ` [PATCH 07/47] RDMA/bnxt_re: " Bart Van Assche
2017-10-06 21:32   ` [PATCH 08/47] RDMA/bnxt_re: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:32   ` [PATCH 09/47] RDMA/cxgb3: Annotate locking assumptions Bart Van Assche
     [not found]     ` <20171006213333.6721-10-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:05       ` Steve Wise
2017-10-06 21:32   ` [PATCH 10/47] RDMA/cxgb3: Annotate an RCU pointer Bart Van Assche
     [not found]     ` <20171006213333.6721-11-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:06       ` Steve Wise
2017-10-06 21:32   ` [PATCH 11/47] RDMA/cxgb3: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <20171006213333.6721-12-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:06       ` Steve Wise
2017-10-06 21:32   ` [PATCH 12/47] RDMA/cxgb4: Fix indentation Bart Van Assche
     [not found]     ` <20171006213333.6721-13-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:10       ` Steve Wise
2017-10-06 21:32   ` [PATCH 13/47] RDMA/cxgb4: Declare a local variable 'static' Bart Van Assche
     [not found]     ` <20171006213333.6721-14-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:09       ` Steve Wise
2017-10-09 23:20         ` Bart Van Assche
     [not found]           ` <1507591219.2674.58.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10  3:59             ` Leon Romanovsky
     [not found]               ` <20171010035909.GI1252-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 16:16                 ` Bart Van Assche
2017-10-06 21:33   ` [PATCH 14/47] RDMA/cxgb4: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-15-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:08       ` Steve Wise
2017-10-06 21:33   ` [PATCH 15/47] RDMA/cxgb4: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <20171006213333.6721-16-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 22:07       ` Steve Wise
2017-10-06 21:33   ` [PATCH 16/47] IB/hfi1: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-17-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 19:50       ` Dennis Dalessandro
2017-10-06 21:33   ` [PATCH 17/47] IB/hfi1: Remove set-but-not-used variables Bart Van Assche
     [not found]     ` <20171006213333.6721-18-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:45       ` Dennis Dalessandro
2017-10-06 21:33   ` [PATCH 18/47] IB/hfi1: Define hfi1_handle_cnp_tbl[] once Bart Van Assche
     [not found]     ` <20171006213333.6721-19-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:54       ` Dennis Dalessandro
2017-10-06 21:33   ` [PATCH 19/47] IB/hns: Annotate iomem pointers correctly Bart Van Assche
     [not found]     ` <20171006213333.6721-20-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:42       ` Leon Romanovsky
     [not found]         ` <20171008134219.GB25829-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-09 17:10           ` Bart Van Assche
2017-10-06 21:33   ` [PATCH 20/47] IB/hns: Declare local functions 'static' Bart Van Assche
     [not found]     ` <20171006213333.6721-21-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:44       ` Leon Romanovsky
2017-10-06 21:33   ` [PATCH 21/47] RDMA/i40iw: Fix a race condition Bart Van Assche
     [not found]     ` <20171006213333.6721-22-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 22:04       ` Shiraz Saleem
2017-10-06 21:33   ` [PATCH 22/47] RDMA/i40iw: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-23-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 22:04       ` Shiraz Saleem
2017-10-06 21:33   ` [PATCH 23/47] RDMA/i40iw: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <20171006213333.6721-24-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 22:05       ` Shiraz Saleem
2017-10-06 21:33   ` [PATCH 24/47] IB/mthca: Fix indentation Bart Van Assche
2017-10-06 21:33   ` [PATCH 25/47] IB/mlx4: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-26-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08  7:50       ` Leon Romanovsky
2017-10-06 21:33   ` [PATCH 26/47] IB/mlx5: " Bart Van Assche
     [not found]     ` <20171006213333.6721-27-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08  7:55       ` Leon Romanovsky
2017-10-06 21:33   ` [PATCH 27/47] IB/mlx5: Remove a set-but-not-used variable Bart Van Assche
     [not found]     ` <20171006213333.6721-28-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08  7:55       ` Leon Romanovsky
2017-10-06 21:33   ` [PATCH 28/47] IB/nes: Fix indentation Bart Van Assche
2017-10-06 21:33   ` [PATCH 29/47] IB/nes: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-06 21:33   ` [PATCH 30/47] IB/nes: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:33   ` [PATCH 31/47] IB/nes: Fix a race condition in nes_inetaddr_event() Bart Van Assche
2017-10-06 21:33   ` [PATCH 32/47] RDMA/ocrdma: Use NULL instead of 0 to represent a pointer Bart Van Assche
2017-10-06 21:33   ` [PATCH 33/47] RDMA/ocrdma: Suppress gcc 7 fall-through complaints Bart Van Assche
2017-10-06 21:33   ` [PATCH 34/47] RDMA/ocrdma: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:33   ` [PATCH 35/47] IB/opa: Fix endianness annotation of opa_is_extended_lid() Bart Van Assche
     [not found]     ` <20171006213333.6721-36-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 13:59       ` Dennis Dalessandro
2017-10-06 21:33   ` [PATCH 36/47] RDMA/qedr: Use NULL instead of 0 to represent a pointer Bart Van Assche
2017-10-06 21:33   ` [PATCH 37/47] RDMA/qedr: Declare local functions static Bart Van Assche
2017-10-06 21:33   ` [PATCH 38/47] RDMA/qedr: Annotate iomem pointers correctly Bart Van Assche
2017-10-06 21:33   ` [PATCH 39/47] RDMA/qedr: Remove set-but-not-used variables Bart Van Assche
2017-10-06 21:33   ` [PATCH 40/47] IB/qib: Make qib_inc_eeprom_err() macro more safe to use Bart Van Assche
     [not found]     ` <20171006213333.6721-41-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 14:15       ` Marciniszyn, Mike
     [not found]         ` <32E1700B9017364D9B60AED9960492BC3442AAD2-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 15:08           ` Bart Van Assche
     [not found]             ` <1507648081.2815.5.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 15:36               ` Marciniszyn, Mike
     [not found]                 ` <32E1700B9017364D9B60AED9960492BC3442ADF5-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 17:59                   ` Bart Van Assche
     [not found]                     ` <1507658390.2815.48.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 18:08                       ` Leon Romanovsky
     [not found]                         ` <20171010180809.GI2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 18:25                           ` Bart Van Assche
     [not found]                             ` <1507659918.2815.50.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 18:33                               ` Leon Romanovsky
2017-10-10 20:40                               ` Marciniszyn, Mike
2017-10-06 21:33   ` Bart Van Assche [this message]
     [not found]     ` <20171006213333.6721-42-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 13:56       ` [PATCH 41/47] IB/qib: Suppress gcc 7 fall-through complaints Marciniszyn, Mike
     [not found]         ` <32E1700B9017364D9B60AED9960492BC3442AA1D-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 15:07           ` Bart Van Assche
2017-10-06 21:33   ` [PATCH 42/47] IB/qib: Remove set-but-not-used variables Bart Van Assche
     [not found]     ` <20171006213333.6721-43-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 20:25       ` Marciniszyn, Mike
     [not found]         ` <32E1700B9017364D9B60AED9960492BC3442B95A-RjuIdWtd+YbTXloPLtfHfbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-10-10 20:40           ` Bart Van Assche
     [not found]             ` <1507668036.2815.55.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-12  8:44               ` Leon Romanovsky
     [not found]                 ` <20171012084412.GO2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-12 15:45                   ` Bart Van Assche
     [not found]                     ` <1507823130.2448.16.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-12 15:54                       ` Leon Romanovsky
2017-10-06 21:33   ` [PATCH 43/47] RDMA/rdmavt: Suppress gcc 7 fall-through complaints Bart Van Assche
     [not found]     ` <20171006213333.6721-44-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 19:51       ` Dennis Dalessandro
2017-10-06 21:33   ` [PATCH 44/47] RDMA/rxe: " Bart Van Assche
     [not found]     ` <20171006213333.6721-45-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:45       ` Leon Romanovsky
2017-10-06 21:33   ` [PATCH 45/47] RDMA/usnic: Make the compiler check declaration consistency during compilation Bart Van Assche
2017-10-06 21:33   ` [PATCH 46/47] RDMA/usnic: Remove a set-but-not-used variable Bart Van Assche
2017-10-06 21:33   ` [PATCH 47/47] RDMA/usnic: Instantiate data structures once Bart Van Assche
2017-10-09 16:51   ` [PATCH 00/47] Address issues detected by static analysis tools Doug Ledford
     [not found]     ` <1507567892.46071.44.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-11 14:03       ` Dennis Dalessandro
     [not found]         ` <5d2b3adc-1a19-8acf-9915-d97296be9079-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-10-11 14:55           ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006213333.6721-42-bart.vanassche@wdc.com \
    --to=bart.vanassche-sjgp3ctcywe@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.