All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case
Date: Sun, 8 Oct 2017 23:12:28 -0400	[thread overview]
Message-ID: <20171009031228.GR25966@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5Duy+_ie6AUpmJr-x_3mB-W6bV2KE4=qG7B7dqskhgm4g@mail.gmail.com>

On Sun, Oct 08, 2017 at 10:56:26PM -0300, Fabio Estevam wrote:
> On Sun, Oct 8, 2017 at 11:04 AM, Jonathan Gray <jsg@jsg.id.au> wrote:
> 
> > It turns out to be
> >
> > commit 2460098cffacd18729262e3ed36656e6943783ed
> > Author: Tom Rini <trini@konsulko.com>
> > Date:   Fri Sep 22 07:37:43 2017 -0400
> >
> >     fs/fat: Reduce stack usage
> >
> >     We have limited stack in SPL builds.  Drop itrblock and move to
> >     malloc/free of itr to move this off of the stack.  As part of this fix a
> >     double-free issue in fat_size().
> >
> >     Signed-off-by: Tom Rini <trini@konsulko.com>
> >     ---
> >     Rework to use malloc/free as moving this to a global overflows some SH
> >     targets.
> >
> >  fs/fat/fat.c | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> >
> > With that reverted I just get the efi loader problem, no alignment errors.
> 
> Thanks for doing the bisect.
> 
> Tom, can you prepare a fix for this?

No, this is a required fix for other platforms.  Why is this failing in
the particular case that it's failing in?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171008/71018eda/attachment.sig>

  reply	other threads:[~2017-10-09  3:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 16:29 [U-Boot] [PATCH] disk: part_dos: Use the original allocation scheme for the SPL case Fabio Estevam
2017-10-04 17:12 ` Rob Clark
2017-10-05  4:36   ` Jonathan Gray
2017-10-05  9:05     ` Rob Clark
2017-10-06  4:35       ` Jonathan Gray
2017-10-06 12:21         ` Rob Clark
2017-10-06 12:26           ` Rob Clark
2017-10-07  2:08           ` Jonathan Gray
2017-10-07 12:23             ` Rob Clark
2017-10-07 13:20               ` Jonathan Gray
2017-10-08 23:00               ` Peter Robinson
2017-10-07 17:46     ` Fabio Estevam
2017-10-08  1:06       ` Jonathan Gray
2017-10-08 12:56         ` Fabio Estevam
2017-10-08 14:04           ` Jonathan Gray
2017-10-09  1:56             ` Fabio Estevam
2017-10-09  3:12               ` Tom Rini [this message]
2017-10-09  6:19                 ` Jonathan Gray
2017-10-09 12:08                   ` Tom Rini
2017-10-05 11:01 ` Peter Robinson
2017-10-05 21:52 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171009031228.GR25966@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.