From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755003AbdJIRmp (ORCPT ); Mon, 9 Oct 2017 13:42:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51840 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754739AbdJIRmo (ORCPT ); Mon, 9 Oct 2017 13:42:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2867280E73 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mst@redhat.com Date: Mon, 9 Oct 2017 20:42:42 +0300 From: "Michael S. Tsirkin" To: Bart Van Assche Cc: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Message-ID: <20171009204139-mutt-send-email-mst@kernel.org> References: <20171006172353.16758-1-bart.vanassche@wdc.com> <20171009162008-mutt-send-email-mst@kernel.org> <1507561661.2674.3.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507561661.2674.3.camel@wdc.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 09 Oct 2017 17:42:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2017 at 03:07:42PM +0000, Bart Van Assche wrote: > On Mon, 2017-10-09 at 16:22 +0300, Michael S. Tsirkin wrote: > > On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote: > > > The purpose of patch "linux/types.h: enable endian checks for all > > > sparse builds" was to encourage driver authors to annotate > > > endianness correctly in their drivers. However, since that patch > > > went upstream no endianness annotations in drivers have been fixed. > > > I think that this shows that the followed approach does not work, > > > probably because several driver authors do not use sparse. Restore > > > the ability to disable sparse endianness checks such that it > > > becomes again easy to review other sparse diagnostics for people > > > who want to analyze drivers they are not the author of. > > > > > > References: commit 05de97003c77 ("linux/types.h: enable endian checks for all sparse builds") > > > Signed-off-by: Bart Van Assche > > > Cc: Christoph Hellwig > > > Cc: Linus Torvalds > > > > I still think the new default is good. You probably want ability to > > disable these checks selectively for the specific drivers though. Makes > > it easier to spot what needs to be fixed. > > Hello MST, > > I agree with what you wrote. And what you described is what my patch implements > - keep endianness checking enabled by default and make it possible to disable it > selectively. Does that mean that you agree with the patch I posted? > > Thanks, > > Bart. I just mean I'd expect a patchset setting the flag for the broken drivers. Presumably this will help trigger some action. -- MST