From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756355AbdJJObR (ORCPT ); Tue, 10 Oct 2017 10:31:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:41662 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756287AbdJJObQ (ORCPT ); Tue, 10 Oct 2017 10:31:16 -0400 Date: Tue, 10 Oct 2017 16:31:13 +0200 From: Michal Hocko To: Dave Hansen Cc: kemi , "Luis R . Rodriguez" , Kees Cook , Andrew Morton , Jonathan Corbet , Mel Gorman , Johannes Weiner , Christopher Lameter , Sebastian Andrzej Siewior , Vlastimil Babka , Tim Chen , Andi Kleen , Jesper Dangaard Brouer , Ying Huang , Aaron Lu , Proc sysctl , Linux MM , Linux Kernel Subject: Re: [PATCH v3] mm, sysctl: make NUMA stats configurable Message-ID: <20171010143113.gk6iqcrguefhhlmr@dhcp22.suse.cz> References: <1506579101-5457-1-git-send-email-kemi.wang@intel.com> <20171003092352.2wh2jbtt2dudfi5a@dhcp22.suse.cz> <221a1e93-ee33-d598-67de-d6071f192040@intel.com> <20171009075549.pzohdnerillwuhqo@dhcp22.suse.cz> <20171010054902.sqp6yyid6qqhpsrt@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10-10-17 07:29:31, Dave Hansen wrote: > On 10/09/2017 10:49 PM, Michal Hocko wrote: > > On Mon 09-10-17 09:55:49, Michal Hocko wrote: > >> I haven't checked closely but what happens (or should happen) when you > >> do a partial read? Should you get an inconsistent results? Or is this > >> impossible? > > Well, after thinking about it little bit more, partial reads are always > > inconsistent so this wouldn't add a new problem. > > > > Anyway I still stand by my position that this sounds over-engineered and > > a simple 0/1 resp. on/off interface would be both simpler and safer. If > > anybody wants an auto mode it can be added later (as a value 2 resp. > > auto). > > 0/1 with the default set to the strict, slower mode? yes, keep the current semantic and allow users who care to disable something that stands in the way. -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 10 Oct 2017 16:31:13 +0200 From: Michal Hocko To: Dave Hansen Cc: kemi , "Luis R . Rodriguez" , Kees Cook , Andrew Morton , Jonathan Corbet , Mel Gorman , Johannes Weiner , Christopher Lameter , Sebastian Andrzej Siewior , Vlastimil Babka , Tim Chen , Andi Kleen , Jesper Dangaard Brouer , Ying Huang , Aaron Lu , Proc sysctl , Linux MM , Linux Kernel Subject: Re: [PATCH v3] mm, sysctl: make NUMA stats configurable Message-ID: <20171010143113.gk6iqcrguefhhlmr@dhcp22.suse.cz> References: <1506579101-5457-1-git-send-email-kemi.wang@intel.com> <20171003092352.2wh2jbtt2dudfi5a@dhcp22.suse.cz> <221a1e93-ee33-d598-67de-d6071f192040@intel.com> <20171009075549.pzohdnerillwuhqo@dhcp22.suse.cz> <20171010054902.sqp6yyid6qqhpsrt@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: On Tue 10-10-17 07:29:31, Dave Hansen wrote: > On 10/09/2017 10:49 PM, Michal Hocko wrote: > > On Mon 09-10-17 09:55:49, Michal Hocko wrote: > >> I haven't checked closely but what happens (or should happen) when you > >> do a partial read? Should you get an inconsistent results? Or is this > >> impossible? > > Well, after thinking about it little bit more, partial reads are always > > inconsistent so this wouldn't add a new problem. > > > > Anyway I still stand by my position that this sounds over-engineered and > > a simple 0/1 resp. on/off interface would be both simpler and safer. If > > anybody wants an auto mode it can be added later (as a value 2 resp. > > auto). > > 0/1 with the default set to the strict, slower mode? yes, keep the current semantic and allow users who care to disable something that stands in the way. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org