From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932360AbdJJQFb (ORCPT ); Tue, 10 Oct 2017 12:05:31 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52674 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932075AbdJJQF3 (ORCPT ); Tue, 10 Oct 2017 12:05:29 -0400 Date: Tue, 10 Oct 2017 09:05:23 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: David Howells , linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, mark.rutland@arm.com, linux-arch@vger.kernel.org, will.deacon@arm.com, Jonathan Corbet , Alexander Kuleshov Subject: Re: [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends() Reply-To: paulmck@linux.vnet.ibm.com References: <1507594969-8347-12-git-send-email-paulmck@linux.vnet.ibm.com> <20171010001951.GA6476@linux.vnet.ibm.com> <8079.1507628146@warthog.procyon.org.uk> <20171010155042.GD3521@linux.vnet.ibm.com> <20171010155451.wv2dfirmra5aeake@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171010155451.wv2dfirmra5aeake@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17101016-0040-0000-0000-000003B07D49 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007873; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000235; SDB=6.00929171; UDB=6.00467654; IPR=6.00709442; BA=6.00005632; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017476; XFM=3.00000015; UTC=2017-10-10 16:05:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101016-0041-0000-0000-000007A57E0D Message-Id: <20171010160523.GH3521@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-10_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710100226 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2017 at 05:54:51PM +0200, Peter Zijlstra wrote: > On Tue, Oct 10, 2017 at 08:50:42AM -0700, Paul E. McKenney wrote: > > + /* We need a barrier between the read of the pointer, > > + * which is supplied by the above READ_ONCE(). > > */ > > > /* We need a barrier between the read of the pointer > > * and dereferencing the pointer - but only if we are > > * actually going to dereference it. > > */ > > Could you also fix those "disgusting drug-induced crap" comment styles > while you're there anyway? > > http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html If Dave is OK with it, I will do so on my next pass. Thanx, Paul