All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
Cc: "leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 3/7] IB/srpt: Change default behavior from using SRQ to not using SRQ
Date: Tue, 10 Oct 2017 11:04:29 -0600	[thread overview]
Message-ID: <20171010170429.GA21288@obsidianresearch.com> (raw)
In-Reply-To: <1507651473.2815.20.camel-Sjgp3cTcYWE@public.gmane.org>

On Tue, Oct 10, 2017 at 04:04:34PM +0000, Bart Van Assche wrote:
> On Tue, 2017-10-10 at 18:44 +0300, Leon Romanovsky wrote:
> > Bart clearly mentioned disadvantages of XRQ and left me wonder why user
> > needs to enable it anyway. This is what I'm asking and this is what I'm
> > hoping to see in the commit message.
> 
> I assume that you meant SRQ instead of XRQ? For HCA's that support SRQ a
> choice has to be made between the lower memory usage of SRQ or the higher
> performance of RC. I think only the user can make that choice. Hence the
> new kernel module parameter.

considering our general dislike of module parameters, could you
achieve this via some communicationfrom srp_daemon instead?

Perhaps even on a per target basis?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-10-10 17:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 21:42 [PATCH 0/7] SRP patches for kernel v4.15 Bart Van Assche
2017-10-06 21:42 ` [PATCH 4/7] IB/srp: Avoid a cable pull can trigger a kernel crash Bart Van Assche
     [not found]   ` <20171006214243.11296-5-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 13:22     ` Leon Romanovsky
2017-10-08 13:22       ` Leon Romanovsky
2017-10-09 17:02       ` Bart Van Assche
2017-10-11 12:36     ` Sagi Grimberg
2017-10-11 12:36       ` Sagi Grimberg
     [not found] ` <20171006214243.11296-1-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-06 21:42   ` [PATCH 1/7] IB/srpt: Limit the send and receive queue sizes to what the HCA supports Bart Van Assche
     [not found]     ` <20171006214243.11296-2-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 12:31       ` Sagi Grimberg
2017-10-06 21:42   ` [PATCH 2/7] IB/srpt: Cache global L_Key Bart Van Assche
     [not found]     ` <20171006214243.11296-3-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08  9:01       ` Christoph Hellwig
     [not found]         ` <20171008090107.GA17153-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-10-09 16:57           ` Bart Van Assche
2017-10-06 21:42   ` [PATCH 3/7] IB/srpt: Change default behavior from using SRQ to not using SRQ Bart Van Assche
     [not found]     ` <20171006214243.11296-4-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-08 10:03       ` Leon Romanovsky
     [not found]         ` <20171008100317.GR25829-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-09 16:56           ` Doug Ledford
     [not found]             ` <1507568205.46071.46.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-09 17:01               ` Bart Van Assche
     [not found]                 ` <1507568492.2674.11.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-09 17:12                   ` Doug Ledford
2017-10-10  4:14                   ` Leon Romanovsky
     [not found]                     ` <20171010041423.GJ1252-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 14:34                       ` Doug Ledford
     [not found]                         ` <9443ec1f-0acd-9fa3-4621-a29085d2c606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-10 15:00                           ` Leon Romanovsky
     [not found]                             ` <20171010150018.GC2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 15:13                               ` Doug Ledford
     [not found]                                 ` <1507648402.46071.53.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-10 15:44                                   ` Leon Romanovsky
     [not found]                                     ` <20171010154439.GE2106-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-10-10 16:04                                       ` Bart Van Assche
     [not found]                                         ` <1507651473.2815.20.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 17:04                                           ` Jason Gunthorpe [this message]
     [not found]                                             ` <20171010170429.GA21288-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-10-10 17:10                                               ` Bart Van Assche
     [not found]                                                 ` <1507655454.2815.43.camel-Sjgp3cTcYWE@public.gmane.org>
2017-10-10 18:01                                                   ` Leon Romanovsky
2017-10-10 16:11                                       ` Doug Ledford
2017-10-06 21:42   ` [PATCH 5/7] IB/srp: Remove second argument of srp_destroy_qp() Bart Van Assche
     [not found]     ` <20171006214243.11296-6-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 12:36       ` Sagi Grimberg
2017-10-06 21:42   ` [PATCH 6/7] IB/srp: Cache global rkey Bart Van Assche
2017-10-06 21:42   ` [PATCH 7/7] IB/srp: Make CM timeout dependent on subnet timeout Bart Van Assche
     [not found]     ` <20171006214243.11296-8-bart.vanassche-Sjgp3cTcYWE@public.gmane.org>
2017-10-11 12:38       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010170429.GA21288@obsidianresearch.com \
    --to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
    --cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.