From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbdJKWTN (ORCPT ); Wed, 11 Oct 2017 18:19:13 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750848AbdJKWTK (ORCPT ); Wed, 11 Oct 2017 18:19:10 -0400 Date: Wed, 11 Oct 2017 15:19:08 -0700 (PDT) Message-Id: <20171011.151908.1325409031052082911.davem@davemloft.net> To: keescook@chromium.org Cc: khc@pm.waw.pl, netdev@vger.kernel.org, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hdlc: Convert timers to use timer_setup() From: David Miller In-Reply-To: <20171010220833.GA97664@beast> References: <20171010220833.GA97664@beast> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 11 Oct 2017 15:19:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Tue, 10 Oct 2017 15:08:33 -0700 > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. This adds a pointer back to the > net_device, and drops needless open-coded resetting of the .function and > .data fields. > > Cc: David S. Miller > Cc: Krzysztof Halasa > Cc: netdev@vger.kernel.org > Signed-off-by: Kees Cook > --- > This requires commit 686fef928bba ("timer: Prepare to change timer > callback argument type") in v4.14-rc3, but should be otherwise > stand-alone. This doesn't apply cleanly to net-next, please respin.