All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Inki Dae <inki.dae@samsung.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH v3 0/5] Fix problems with Exynos4412 ISP clocks
Date: Wed, 11 Oct 2017 11:25:10 +0200	[thread overview]
Message-ID: <20171011092515.1698-1-m.szyprowski@samsung.com> (raw)
In-Reply-To: CGME20171011092520eucas1p15370b8f6ecbe832b3fbb1e52ba9ed040@eucas1p1.samsung.com

Hi!

Exynos4412 ISP clock controller is located in the SOC area, which belongs
to ISP power domain. This was not properly handled by the current
Exynos4-clk driver. This patchset instantiates a separate clock driver
for those clocks, updates all clients of ISP clocks and ensures that
the driver is properly integrated in ISP power domin using runtime PM
feature of the clock framework.

This finally solves all the mysterious freezes in accessing ISP clocks
when ISP power domain is disabled.

The last patch breaks support for old dtbs. It can be applied when all
boards are updated. Exynos4412 ISP subsystem is only used by Trats2
boards, for which kernel is updated always together with the dtb file,
so the last patch can be applied to the next kernel release after merging
the DTS patch.

This patchset requires clocks runtime PM support ("Add runtime PM support
for clocks (on Exynos SoC example)" v9 patchset), which has been recently
merged to clk-next.

Best regards
Marek Szyprowski
Samsung R&D Institute Poland


Changelog:
v3:
- moved dt-bindings changes to separate patch and rewrote dt bindings
  documentation as requrested by Rob Herring

v2: https://www.spinics.net/lists/linux-samsung-soc/msg60737.html
- fixed minor issues pointed by Krzysztof Kozlowski

v1: https://www.spinics.net/lists/linux-clk/msg20274.html
- initial version of this patchset

Patch summary:

Marek Szyprowski (5):
  clk: samsung: Instantiate Exynos4412 ISP clocks only when available
  clk: samsung: Add dt bindings for Exynos4412 ISP clock controller
  clk: samsung: Add a separate driver for Exynos4412 ISP clocks
  ARM: dts: exynos: Add Exynos4412 ISP clock controller
  clk: samsung: Remove obsolete code for Exynos4412 ISP clocks

 .../devicetree/bindings/clock/exynos4-clock.txt    |  43 +++++
 arch/arm/boot/dts/exynos4412.dtsi                  |  71 ++++----
 drivers/clk/samsung/Makefile                       |   1 +
 drivers/clk/samsung/clk-exynos4.c                  |  66 +-------
 drivers/clk/samsung/clk-exynos4412-isp.c           | 179 +++++++++++++++++++++
 include/dt-bindings/clock/exynos4.h                |  65 ++++----
 6 files changed, 303 insertions(+), 122 deletions(-)
 create mode 100644 drivers/clk/samsung/clk-exynos4412-isp.c

-- 
2.14.2


       reply	other threads:[~2017-10-11  9:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171011092520eucas1p15370b8f6ecbe832b3fbb1e52ba9ed040@eucas1p1.samsung.com>
2017-10-11  9:25 ` Marek Szyprowski [this message]
     [not found]   ` <CGME20171011092520eucas1p2a86dcd52a7c0c4b329563e5eaad3fd76@eucas1p2.samsung.com>
2017-10-11  9:25     ` [PATCH v3 1/5] clk: samsung: Instantiate Exynos4412 ISP clocks only when available Marek Szyprowski
     [not found]   ` <CGME20171011092521eucas1p12fa702013b7bdbb4f9250e9da3fda8a1@eucas1p1.samsung.com>
     [not found]     ` <20171011092515.1698-1-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-10-11  9:25       ` [PATCH v3 2/5] clk: samsung: Add dt bindings for Exynos4412 ISP clock controller Marek Szyprowski
2017-10-11  9:25         ` Marek Szyprowski
2017-10-11 17:05         ` Krzysztof Kozlowski
2017-10-12  6:47           ` Marek Szyprowski
2017-10-12  7:08             ` Krzysztof Kozlowski
     [not found]               ` <CAJKOXPe332r+2gAeiGAkzOVrLZ-ygDpneNG134GmY-VZ6fUEGA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-13 22:02                 ` Rob Herring
2017-10-13 22:02                   ` Rob Herring
     [not found]         ` <20171011092515.1698-3-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-10-13 22:03           ` Rob Herring
2017-10-13 22:03             ` Rob Herring
     [not found]   ` <CGME20171011092521eucas1p29aeadc2a63aea49b985b6827022a1b09@eucas1p2.samsung.com>
2017-10-11  9:25     ` [PATCH v3 3/5] clk: samsung: Add a separate driver for Exynos4412 ISP clocks Marek Szyprowski
     [not found]   ` <CGME20171011092522eucas1p13c442dd9daa51e610618b39ee436e100@eucas1p1.samsung.com>
2017-10-11  9:25     ` [PATCH v3 4/5] ARM: dts: exynos: Add Exynos4412 ISP clock controller Marek Szyprowski
2017-11-29 18:08       ` Krzysztof Kozlowski
     [not found]   ` <CGME20171011092522eucas1p2804557c3fa5b2314911ac6038b3fccd1@eucas1p2.samsung.com>
2017-10-11  9:25     ` [PATCH v3 5/5] clk: samsung: Remove obsolete code for Exynos4412 ISP clocks Marek Szyprowski
2018-09-07 20:10       ` Sylwester Nawrocki
2017-10-16 13:24   ` [PATCH v3 0/5] Fix problems with " Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011092515.1698-1-m.szyprowski@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.