From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757283AbdJKJmn (ORCPT ); Wed, 11 Oct 2017 05:42:43 -0400 Received: from foss.arm.com ([217.140.101.70]:57296 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835AbdJKJmk (ORCPT ); Wed, 11 Oct 2017 05:42:40 -0400 From: Punit Agrawal To: linux-kernel@vger.kernel.org Cc: Punit Agrawal , marc.zyngier@arm.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/3] irqchip/gic-v3: Report firmwware provided address in case of error Date: Wed, 11 Oct 2017 10:41:47 +0100 Message-Id: <20171011094148.15674-3-punit.agrawal@arm.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171011094148.15674-1-punit.agrawal@arm.com> References: <20171011094148.15674-1-punit.agrawal@arm.com> X-ARM-No-Footer: FoSSMail Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When a redistributor is not found at the address provided by the firmware, report the firmware provided address to help user identify the offending firmware data. Signed-off-by: Punit Agrawal Cc: Marc Zyngier --- drivers/irqchip/irq-gic-v3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 8cb383b6e605..881d327c53fa 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -430,13 +430,14 @@ static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *)) for (i = 0; i < gic_data.nr_redist_regions; i++) { void __iomem *ptr = gic_data.redist_regions[i].redist_base; + struct resource *res = &gic_data.redist_regions[i].res; u64 typer; u32 reg; reg = readl_relaxed(ptr + GICR_PIDR2) & GIC_PIDR2_ARCH_MASK; if (reg != GIC_PIDR2_ARCH_GICv3 && reg != GIC_PIDR2_ARCH_GICv4) { /* We're in trouble... */ - pr_warn("No redistributor present @%p\n", ptr); + pr_warn("No redistributor present @%llx\n", res->start); break; } -- 2.14.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: punit.agrawal@arm.com (Punit Agrawal) Date: Wed, 11 Oct 2017 10:41:47 +0100 Subject: [PATCH 2/3] irqchip/gic-v3: Report firmwware provided address in case of error In-Reply-To: <20171011094148.15674-1-punit.agrawal@arm.com> References: <20171011094148.15674-1-punit.agrawal@arm.com> Message-ID: <20171011094148.15674-3-punit.agrawal@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org When a redistributor is not found at the address provided by the firmware, report the firmware provided address to help user identify the offending firmware data. Signed-off-by: Punit Agrawal Cc: Marc Zyngier --- drivers/irqchip/irq-gic-v3.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 8cb383b6e605..881d327c53fa 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -430,13 +430,14 @@ static int gic_iterate_rdists(int (*fn)(struct redist_region *, void __iomem *)) for (i = 0; i < gic_data.nr_redist_regions; i++) { void __iomem *ptr = gic_data.redist_regions[i].redist_base; + struct resource *res = &gic_data.redist_regions[i].res; u64 typer; u32 reg; reg = readl_relaxed(ptr + GICR_PIDR2) & GIC_PIDR2_ARCH_MASK; if (reg != GIC_PIDR2_ARCH_GICv3 && reg != GIC_PIDR2_ARCH_GICv4) { /* We're in trouble... */ - pr_warn("No redistributor present @%p\n", ptr); + pr_warn("No redistributor present @%llx\n", res->start); break; } -- 2.14.1