From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:47319 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbdJKQzj (ORCPT ); Wed, 11 Oct 2017 12:55:39 -0400 Received: by mail-pg0-f46.google.com with SMTP id r25so1300938pgn.4 for ; Wed, 11 Oct 2017 09:55:39 -0700 (PDT) Date: Wed, 11 Oct 2017 09:55:31 -0700 From: Stephen Hemminger To: Greg KH Cc: Dexuan Cui , "stable@vger.kernel.org" , KY Srinivasan , Stephen Hemminger Subject: Re: [PATCH] vmbus: fix missing signaling in hv_signal_on_read() Message-ID: <20171011095531.52546c90@xeon-e3> In-Reply-To: <20171010150129.GA28183@kroah.com> References: <20170816154946.7495-1-sthemmin@microsoft.com> <20170816161040.GA3550@kroah.com> <20170816091619.5e20950b@xeon-e3> <20170907042725.GA17231@kroah.com> <20170907084113.7b31a9cd@xeon-e3> <20171010150129.GA28183@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Tue, 10 Oct 2017 17:01:29 +0200 Greg KH wrote: > On Thu, Sep 07, 2017 at 08:41:13AM -0700, Stephen Hemminger wrote: > > On Thu, 7 Sep 2017 06:27:25 +0200 > > Greg KH wrote: > > > > > On Thu, Sep 07, 2017 at 12:54:09AM +0000, Dexuan Cui wrote: > > > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > > > Sent: Wednesday, August 16, 2017 9:16 AM > > > > > To: Greg KH > > > > > Cc: KY Srinivasan ; Dexuan Cui ; > > > > > devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; > > > > > stable@vger.kernel.org; Stephen Hemminger ; > > > > > John Starks > > > > > Subject: Re: [PATCH] vmbus: fix missing signaling in hv_signal_on_read() > > > > > > > > > > On Wed, 16 Aug 2017 09:10:40 -0700 > > > > > Greg KH wrote: > > > > > > > > > > > On Wed, Aug 16, 2017 at 08:49:46AM -0700, Stephen Hemminger wrote: > > > > > > > When the space available before start of reading (cached_write_sz) > > > > > > > is the same as the host required space (pending_sz), we need to > > > > > > > still signal host. > > > > > > > > > > > > > > Fixes: 433e19cf33d3 ("Drivers: hv: vmbus: finally fix > > > > > hv_need_to_signal_on_read()") > > > > > > > > > > > > > > Signed-off-by: John Starks > > > > > > > Signed-off-by: Dexuan Cui > > > > > > > Signed-off-by: Stephen Hemminger > > > > > > > --- > > > > > > > This patch is for 4.13 (and stable). > > > > > > > A different fix is needed for linux-next. > > > > > > > > > > > > Is there a fix for this in Linus's tree? If so, what's the git commit > > > > > > id? We need to wait for that until I can take it in -stable. > > > > > > > > > > There is no commit yet in Linus's tree. Was submitting for both Linus > > > > > and stable. Wasn't sure about the timing since 4.13 might close before he gets > > > > > to it. > > > > > > > > Hi Greg and stable@vger.kernel.org, > > > > We need the patch for the stable kernels: v4.13, v4.12.10 and v4.9.47. > > > > > > > > The patch is not in Linus's tree, because the bug is resolved there by a series > > > > of 4 patches (see the below). > > > > > > > > IMO it's better to apply this small patch to the stable kernels rather than > > > > backporting the 4 big commits? > > > > > > It is always better to backport the original commits. Will they work > > > as-is, or do they need porting? > > > > > > thanks, > > > > > > greg k-h > > > > The four patches apply (and kernel builds and runs) for 4.12.10 and 4.13. > > They do not apply to 4.9 unless several other patches are dragged in. > > Ok, any suggestion of what I should do here? Drag in the series for > 4.13? Something else for 4.9? As long as you all are willing to > "support" whatever we do here, I'll go along with it... > > thanks, > > greg k-h I would prefer the single patch for 4.9 rather than creating increased risk by dragging in the full patch set.