From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [alsa-devel] [Patch v6 1/7] slimbus: Device management on SLIMbus Date: Wed, 11 Oct 2017 15:51:32 +0530 Message-ID: <20171011102132.GG30097@localhost> References: <20171006155136.4682-1-srinivas.kandagatla@linaro.org> <20171006155136.4682-2-srinivas.kandagatla@linaro.org> <20171010104509.GC30097@localhost> <20171010164930.GD30097@localhost> <9e2bb2fa-b391-055e-407e-c93f43428840@linaro.org> <20171011040741.GE30097@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Srinivas Kandagatla Cc: gregkh@linuxfoundation.org, broonie@kernel.org, alsa-devel@alsa-project.org, mark.rutland@arm.com, michael.opdenacker@free-electrons.com, poeschel@lemonage.de, andreas.noever@gmail.com, gong.chen@linux.intel.com, arnd@arndb.de, kheitke@audience.com, bp@suse.de, devicetree@vger.kernel.org, james.hogan@imgtec.com, pawel.moll@arm.com, linux-arm-msm@vger.kernel.org, sharon.dvir1@mail.huji.ac.il, robh+dt@kernel.org, sdharia@codeaurora.org, alan@linux.intel.com, treding@nvidia.com, mathieu.poirier@linaro.org, jkosina@suse.cz, linux-kernel@vger.kernel.org, daniel@ffwll.ch, joe@perches.com, davem@davemloft.net List-Id: linux-arm-msm@vger.kernel.org On Wed, Oct 11, 2017 at 10:42:23AM +0100, Srinivas Kandagatla wrote: > On 11/10/17 05:07, Vinod Koul wrote: > >On Tue, Oct 10, 2017 at 06:21:34PM +0100, Srinivas Kandagatla wrote: > >>On 10/10/17 17:49, Vinod Koul wrote: > >>>>>>+/** > >>>>>>+ * slim_register_controller: Controller bring-up and registration. > >>... > >>>>>>+ > >>>>>>+ mutex_init(&ctrl->m_ctrl); > >>>>>>+ ret = device_register(&ctrl->dev); > >>>>> > >>>>>one more device_register?? Can you explain why > >>>>> > >>>> > >>>>This is a device for each controller. > >>> > >>>wont the controller have its own platform_device? > >> > >>Reason could be that slim_register controller can be called from any code > >>not just platform devices.. > > > >ah which cases would those be. I was expecting that you would have a > >platform_device as a slimbus controller which would call slim_register? > As of now there is only one controller which uses platform driver, but in > future there might be more, but this is something which makes the slimbus > core more flexible. even if you have more controllers wouldn't we have similar number of platform devices. Each instance of the link/controller would have its device node. Thanks -- ~Vinod