From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Subject: [PATCH v3 nf-next 0/2] netfilter: x_tables: speed up iptables-restore
Date: Wed, 11 Oct 2017 16:26:05 +0200 [thread overview]
Message-ID: <20171011142607.15026-1-fw@strlen.de> (raw)
iptables-restore can take quite a long time when sytem is busy, in order
of half a minute or more.
The main reason for this is the way ip(6)tables performs table swap:
When xt_replace_table assigns the new ruleset pointer, it does
not wait for other processors to finish with old ruleset.
Instead it relies on the counter sequence lock in get_counters().
This works but this is costly if system is busy as each counter read
operation can possibly be restarted indefinitely.
Instead, make xt_replace_table wait until all processors are known to not
use the old ruleset anymore.
This allows to read the old counters without any locking, no cpu is
using the ruleset anymore so counters can't change either.
next reply other threads:[~2017-10-11 14:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 14:26 Florian Westphal [this message]
2017-10-11 14:26 ` [PATCH v3 nf-next 1/2] netfilter: x_tables: wait until old table isn't used anymore Florian Westphal
2017-10-11 15:09 ` Eric Dumazet
2017-10-11 17:48 ` Florian Westphal
2017-10-11 17:57 ` Eric Dumazet
2017-10-11 18:18 ` Florian Westphal
2017-10-11 18:23 ` Eric Dumazet
2017-10-11 14:26 ` [PATCH v3 nf-next 2/2] netfilter: x_tables: don't use seqlock when fetching old counters Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011142607.15026-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.