From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbdJKPCC (ORCPT ); Wed, 11 Oct 2017 11:02:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58810 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbdJKPCB (ORCPT ); Wed, 11 Oct 2017 11:02:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CF856C04AC41 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=none smtp.mailfrom=jolsa@kernel.org DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com CF856C04AC41 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra , Andi Kleen Subject: [PATCH 00/35] perf annotate: Use generic annotation line Date: Wed, 11 Oct 2017 17:01:23 +0200 Message-Id: <20171011150158.11895-1-jolsa@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 11 Oct 2017 15:02:01 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, I'm working on script profiling support and came up with some generic annotation code changes, which IMO make the code simpler and more generic. The main idea of this patchset is to have generic struct (annotation_line), which holds the common profile data. Having this we can easily add new types, like script annotation support. Currently there's disasm_line support only. It's also available at: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/annotate I'm getting same annotation results for this patchset as in the current perf, but I might have missed something. thanks, jirka --- tools/perf/arch/arm/annotate/instructions.c | 3 +- tools/perf/arch/arm64/annotate/instructions.c | 3 +- tools/perf/arch/powerpc/annotate/instructions.c | 4 +- tools/perf/arch/s390/annotate/instructions.c | 4 +- tools/perf/arch/x86/annotate/instructions.c | 14 +++ tools/perf/builtin-top.c | 2 +- tools/perf/ui/browsers/annotate.c | 404 +++++++++++++++++++++++++++++++++++------------------------------------- tools/perf/ui/gtk/annotate.c | 23 ++--- tools/perf/util/annotate.c | 635 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------ tools/perf/util/annotate.h | 76 ++++++++------ 10 files changed, 609 insertions(+), 559 deletions(-)