From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751914AbdJKP1O (ORCPT ); Wed, 11 Oct 2017 11:27:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:34360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705AbdJKP1N (ORCPT ); Wed, 11 Oct 2017 11:27:13 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A5DE21909 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 11 Oct 2017 12:27:09 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Ingo Molnar , Namhyung Kim , David Ahern , Peter Zijlstra , Andi Kleen Subject: Re: [PATCH 00/35] perf annotate: Use generic annotation line Message-ID: <20171011152709.GC3503@kernel.org> References: <20171011150158.11895-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011150158.11895-1-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu: > hi, > I'm working on script profiling support and came up Can you describe what you mean by "script profiling" and "script annotation"? - Arnaldo > with some generic annotation code changes, which IMO > make the code simpler and more generic. > > The main idea of this patchset is to have generic > struct (annotation_line), which holds the common > profile data. Having this we can easily add new > types, like script annotation support. Currently > there's disasm_line support only. > > It's also available at: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/annotate > > I'm getting same annotation results for this patchset as > in the current perf, but I might have missed something. > > thanks, > jirka > > --- > tools/perf/arch/arm/annotate/instructions.c | 3 +- > tools/perf/arch/arm64/annotate/instructions.c | 3 +- > tools/perf/arch/powerpc/annotate/instructions.c | 4 +- > tools/perf/arch/s390/annotate/instructions.c | 4 +- > tools/perf/arch/x86/annotate/instructions.c | 14 +++ > tools/perf/builtin-top.c | 2 +- > tools/perf/ui/browsers/annotate.c | 404 +++++++++++++++++++++++++++++++++++------------------------------------- > tools/perf/ui/gtk/annotate.c | 23 ++--- > tools/perf/util/annotate.c | 635 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------ > tools/perf/util/annotate.h | 76 ++++++++------ > 10 files changed, 609 insertions(+), 559 deletions(-)