All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [krogoth] [PATCH 1/2] can-utils: update to the latest
Date: Wed, 11 Oct 2017 14:23:56 -0400	[thread overview]
Message-ID: <20171011182356.GX16210@edge> (raw)
In-Reply-To: <b83b4c7e-52e2-14b9-d059-cf42c05d8096@ti.com>

On Wed, Oct 11, 2017 at 08:10:45PM +0200, Jean-Jacques Hiblot wrote:
> 
> 
> On 11/10/2017 20:07, Denys Dmytriyenko wrote:
> >No need, I'll merge them as is.
> Thanks.
> BTW when doing a backport from another branch, should the original
> commit ID and branch be described?

Usually you keep original commit log including all SoBs, after which you 
provide info where it's forward/back-ported from, including original commit 
IDs and then new set of SoBs. For example:

===================================
recipe: change something

This change is due to this and that

Signed-off-by: Author
Signed-off-by: Maintainer

(from layer/branch commit-id)

Signed-off-by: Submitter
===================================

The part above (from layer/branch commit-id) is from the original commit.

This is the practice we use in the Yocto Project and besides helping with 
traceability, speeds up reviewing of backported patches, since they've been 
previously reviewed and accepted.

-- 
Denys


> >On Wed, Oct 11, 2017 at 08:05:06PM +0200, Jean-Jacques Hiblot wrote:
> >>On 11/10/2017 20:02, Denys Dmytriyenko wrote:
> >>>Are these 2 backports from morty? Please keep original commit logs then.
> >>Yes they are backports from morty?
> >>
> >>Do you want me to resend?
> >>
> >>JJ
> >>
> >>>
> >>>On Wed, Oct 11, 2017 at 07:58:44PM +0200, Jean-Jacques Hiblot wrote:
> >>>>Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> >>>>---
> >>>>  meta-arago-distro/recipes-extended/socketcan/can-utils_git.bbappend | 3 +++
> >>>>  1 file changed, 3 insertions(+)
> >>>>  create mode 100644 meta-arago-distro/recipes-extended/socketcan/can-utils_git.bbappend
> >>>>
> >>>>diff --git a/meta-arago-distro/recipes-extended/socketcan/can-utils_git.bbappend b/meta-arago-distro/recipes-extended/socketcan/can-utils_git.bbappend
> >>>>new file mode 100644
> >>>>index 0000000..c0e6666
> >>>>--- /dev/null
> >>>>+++ b/meta-arago-distro/recipes-extended/socketcan/can-utils_git.bbappend
> >>>>@@ -0,0 +1,3 @@
> >>>>+SRCREV = "5b518a0a5fa56856f804372a6b99b518dedb5386"
> >>>>+
> >>>>+PR_append = ".arago0"
> >>>>-- 
> >>>>1.9.1
> >>>>
> 


      reply	other threads:[~2017-10-11 18:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 17:58 [krogoth] [PATCH 1/2] can-utils: update to the latest Jean-Jacques Hiblot
2017-10-11 17:58 ` [krogoth] [PATCH 2/2] packagegroup-*-addons*: replace canutils with can-utils Jean-Jacques Hiblot
2017-10-11 18:02 ` [krogoth] [PATCH 1/2] can-utils: update to the latest Denys Dmytriyenko
2017-10-11 18:05   ` Jean-Jacques Hiblot
2017-10-11 18:07     ` Denys Dmytriyenko
2017-10-11 18:10       ` Jean-Jacques Hiblot
2017-10-11 18:23         ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011182356.GX16210@edge \
    --to=denys@ti.com \
    --cc=jjhiblot@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.