From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbdJLIAN (ORCPT ); Thu, 12 Oct 2017 04:00:13 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:43394 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbdJLIAM (ORCPT ); Thu, 12 Oct 2017 04:00:12 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Thu, 12 Oct 2017 17:00:06 +0900 From: Byungchul Park To: peterz@infradead.org, mingo@kernel.org, rostedt@goodmis.org Cc: linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com Subject: Re: [RESEND PATCH v11 0/2] Make find_later_rq() choose a closer cpu in topology Message-ID: <20171012080005.GM3323@X58A-UD3R> References: <1507617474-21816-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507617474-21816-1-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2017 at 03:37:52PM +0900, Byungchul Park wrote: Any problem with this? Peter, you suggested and I implemented it. Did I do in a wrong way? > Change from v10 > -. modify a comment a bit as Steven suggested > > Change from v9 > -. modify a comment a bit so to be more clear as Juri suggested > > Change from v8 > -. add suggested-by Peterz > -. add several comments > > Change from v7 > -. fix a trivial typo > -. modify commit messages to explain what it does more clearly > -. simplify code with an existing macro > > Change from v6 > -. add a comment about selection of fallback_cpu incase more than one exist > -. modify a comment explaining what we do wrt PREFER_SIBLING > > Change from v5 > -. exclude two patches already picked up by peterz > (sched/deadline: Make find_later_rq() choose a closer cpu in topology) > (sched/deadline: Change return value of cpudl_find()) > -. apply what peterz fixed for 'prefer sibling', into deadline and rt > > Change from v4 > -. remove a patch that might cause huge lock contention > (by spin lock(&cpudl.lock) in a hot path of scheduler) > > Change from v3 > -. rename closest_cpu to best_cpu so that it align with rt > -. protect referring cpudl.elements with cpudl.lock > -. change return value of cpudl_find() to bool > > Change from v2 > -. add support for SD_PREFER_SIBLING > > Change from v1 > -. clean up the patch > > Byungchul Park (2): > sched/deadline: Add support for SD_PREFER_SIBLING on find_later_rq() > sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() > > kernel/sched/deadline.c | 82 ++++++++++++++++++++++++++++++++++++++++++++----- > kernel/sched/rt.c | 80 +++++++++++++++++++++++++++++++++++++++++++++-- > 2 files changed, 152 insertions(+), 10 deletions(-) > > -- > 1.9.1