From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752623AbdJLKby (ORCPT ); Thu, 12 Oct 2017 06:31:54 -0400 Received: from www.llwyncelyn.cymru ([82.70.14.225]:47636 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751165AbdJLKbx (ORCPT ); Thu, 12 Oct 2017 06:31:53 -0400 Date: Thu, 12 Oct 2017 11:31:01 +0100 From: Alan Cox To: David Woodhouse Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Message-ID: <20171012112959.4d2310a8@alans-desktop> In-Reply-To: <1507292755.29211.353.camel@infradead.org> References: <20170923201314.GA14742@amd> <9307201.RrdVcHfbLZ@blindfold> <20171006115514.GF9497@amd> <5423699.qLmXvRyVVn@blindfold> <1507291276.29211.350.camel@infradead.org> <20171006121359.GA14435@amd> <1507292755.29211.353.camel@infradead.org> Organization: Intel Corporation X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Oct 2017 13:25:55 +0100 David Woodhouse wrote: > On Fri, 2017-10-06 at 14:13 +0200, Pavel Machek wrote: > > > You can change 'C++' to 'C99' too, while you're at it :) > > > > No. They are C++ comments... as in... dangerous infection that came > > from C++. Yes, C99 is infected, too, but still C++ is original source > > of infection :-). > > C++ is a different language, and irrelevant here. You could call them > Java comments if you want, but that would be equally silly. In the > kernel, they are C99 comments. Valid, but not our preferred style > (which is fair enough, unlike our idiotic refusal to use C99 integer > types). We might as well allow them. We are using those compiler settings so the cases where your compilation produces different results in C99 and more classic C are no longer a risk 8) int main(int argc, char *argv[]) { int x = 1//**/ -1; if (x == 0) puts("Ewww C99"); exit(0); }