From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Xen-devel <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots()
Date: Thu, 12 Oct 2017 16:13:29 +0100 [thread overview]
Message-ID: <20171012151329.mccqe4mqzm5aqvbl@citrix.com> (raw)
In-Reply-To: <1507816462-15881-4-git-send-email-andrew.cooper3@citrix.com>
On Thu, Oct 12, 2017 at 02:54:22PM +0100, Andrew Cooper wrote:
> There are currently three functions which write L4 pagetables for Xen, but
> they all behave subtly differently. sh_install_xen_entries_in_l4() in
> particular is catering for two different usecases, which makes the safety of
> the linear mappings hard to follow.
>
> By consolidating the L4 pagetable writing in a single function, the resulting
> setup of Xen's virtual layout is easier to understand.
>
> No practical changes to the resulting L4, although the logic has been
> rearranged to avoid rewriting some slots. This changes the zap_ro_mpt
> parameter to simply ro_mpt.
>
> Both {hap,sh}_install_xen_entries_in_l4() get folded into their callers. The
> hap side only a single caller, while the shadow side has two. The shadow
> split helps highlight the correctness of the linear slots.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-12 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 13:54 [PATCH for 4.10 0/3] XSA-243 followup Andrew Cooper
2017-10-12 13:54 ` [PATCH 1/3] Revert "x86/mm: move PV l4 table setup code" and "x86/mm: factor out pv_arch_init_memory" Andrew Cooper
2017-10-12 14:46 ` Wei Liu
2017-10-12 14:55 ` Jan Beulich
2017-10-12 13:54 ` [PATCH 2/3] x86/mm: Consolidate all Xen L2 slot writing into init_xen_pae_l2_slots() Andrew Cooper
2017-10-12 14:57 ` Jan Beulich
2017-10-12 14:59 ` Wei Liu
2017-10-18 11:38 ` George Dunlap
2017-10-12 13:54 ` [PATCH 3/3] x86/mm: Consolidate all Xen L4 slot writing into init_xen_l4_slots() Andrew Cooper
2017-10-12 15:08 ` Jan Beulich
2017-10-12 15:24 ` Andrew Cooper
2017-10-12 15:41 ` Jan Beulich
2017-10-12 15:13 ` Wei Liu [this message]
2017-10-18 11:35 ` George Dunlap
2017-10-13 9:47 ` [PATCH for 4.10 0/3] XSA-243 followup Julien Grall
2017-10-14 17:45 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012151329.mccqe4mqzm5aqvbl@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.