Re: [PATCH 1/4] drm/i915: remove redundant lowfreq_avail setting for DDI

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Oct 12, 2017 at 07:05:30PM +0300, Jani Nikula wrote:
> This is never set to true on DDI platforms, so there's no need to set it
> to false either.
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7e91dc9a0fcf..2faa938f57a3 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9025,8 +9025,6 @@ static int haswell_crtc_compute_clock(struct intel_crtc *crtc,
>  		}
>  	}
>  
> -	crtc->lowfreq_avail = false;
> -

IMO just kill off this thing entirely. It's a g4x only thing, and I'm
not sure it even works there. I have a branch somewhere where I extend
our drrs support to cover all platform (g4x included), but I'd need
to find some extra time to polish the few  remaining rough edges.

In the meantime this thing (assuming it does something) might just
cause random vblank timing errors and whanot, and we don't want that.

>  	return 0;
>  }
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx