All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sricharan R <sricharan@codeaurora.org>
Cc: ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com,
	andy.gross@linaro.org, david.brown@linaro.org,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware authentication optional
Date: Thu, 12 Oct 2017 11:26:24 -0700	[thread overview]
Message-ID: <20171012182624.GH1165@minitux> (raw)
In-Reply-To: <1504154734-12175-2-git-send-email-sricharan@codeaurora.org>

On Wed 30 Aug 21:45 PDT 2017, Sricharan R wrote:

> qcom_mdt_load function loads the mdt type firmware and
> initialises the secure memory as well. Make the initialisation only
> when requested by the caller, so that the function can be used
> by self-authenticating remoteproc as well.
> 
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> ---
>  drivers/soc/qcom/mdt_loader.c       | 70 +++++++++++++++++++++++++++++++------
>  include/linux/soc/qcom/mdt_loader.h |  3 ++
>  2 files changed, 62 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c
> index bd63df0..851f5d7 100644
> --- a/drivers/soc/qcom/mdt_loader.c
> +++ b/drivers/soc/qcom/mdt_loader.c
> @@ -86,9 +86,9 @@ ssize_t qcom_mdt_get_size(const struct firmware *fw)
>   *
>   * Returns 0 on success, negative errno otherwise.
>   */

This kerneldoc is now lacks @pas_init, but as it's just an internal
function and you have kerneldoc on the public functions I suggest that
you drop it.

> -int qcom_mdt_load(struct device *dev, const struct firmware *fw,
> -		  const char *firmware, int pas_id, void *mem_region,
> -		  phys_addr_t mem_phys, size_t mem_size)
> +static int __qcom_mdt_load(struct device *dev, const struct firmware *fw,
> +			   const char *firmware, int pas_id, void *mem_region,
> +			   phys_addr_t mem_phys, size_t mem_size, bool pas_init)

With this you have my Acked-by.

Regards,
Bjorn

  reply	other threads:[~2017-10-12 18:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31  4:45 [PATCH v3 0/6] Add support for Hexagon q6v5-wcss integrated core Sricharan R
2017-08-31  4:45 ` [PATCH v3 1/6] remoteproc: qcom: mdt_loader: Make the firmware authentication optional Sricharan R
2017-10-12 18:26   ` Bjorn Andersson [this message]
2017-10-19  5:22     ` Sricharan R
2017-08-31  4:45 ` [PATCH v3 2/6] remoteproc: Export rproc_elf_get_boot_addr Sricharan R
2017-08-31  4:45 ` [PATCH v3 3/6] remoteproc: qcom: Push reset ops, fw ops, rproc ops in to of_match data Sricharan R
2017-08-31  4:45 ` [PATCH v3 4/6] remoteproc: qcom: Split the head and tail of the q6v5-pil rproc start function Sricharan R
2017-08-31  4:45 ` [PATCH v3 5/6] remoteproc: qcom: Add support for q6v5-wcss pil Sricharan R
2017-08-31  4:45   ` Sricharan R
2017-09-12 14:21   ` Rob Herring
2017-09-13  9:33     ` Sricharan R
2017-08-31  4:45 ` [PATCH v3 6/6] remoteproc: qcom: Add q6v5-wcss rproc ops Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012182624.GH1165@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=sricharan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.