From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH igt] lib: Ask the kernel to quiesce the GPU
Date: Thu, 12 Oct 2017 21:54:42 +0100 [thread overview]
Message-ID: <20171012205442.27049-1-chris@chris-wilson.co.uk> (raw)
Since the introduction of debugfs/i915_drop_caches, we have offered the
ability to wait upon all outstanding batches. This is more efficient and
less error prone (one example is the use of context priorities, we have
to idle at the lowest in order not to jump over any low priority tasks
we want to wait upon) than trying to do it all in userspace. Though we
could if we wanted to, it's just easier to use the existing facility
designed for the purpose -- that we were already partially using!
Note that debugfs/i915_drop_caches has only existed since v4.2.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
---
Just another ping to see if we can work whats going on with pnv-d510.
-Chris
--
lib/drmtest.c | 28 +---------------------------
1 file changed, 1 insertion(+), 27 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 8a07152c..4ae023d7 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -159,35 +159,9 @@ static bool has_known_intel_chipset(int fd)
*/
void gem_quiescent_gpu(int fd)
{
- uint32_t bbe = MI_BATCH_BUFFER_END;
- struct drm_i915_gem_execbuffer2 execbuf;
- struct drm_i915_gem_exec_object2 obj;
- unsigned ring;
-
igt_terminate_spin_batches();
- memset(&obj, 0, sizeof(obj));
- obj.handle = gem_create(fd, 4096);
- gem_write(fd, obj.handle, 0, &bbe, sizeof(&bbe));
-
- memset(&execbuf, 0, sizeof(execbuf));
- execbuf.buffers_ptr = to_user_pointer(&obj);
- execbuf.buffer_count = 1;
-
- for (ring = 0; ring < 1<<6; ring++) {
- execbuf.flags = ring;
- __gem_execbuf(fd, &execbuf);
- }
-
- if (gem_has_bsd2(fd)) {
- execbuf.flags = I915_EXEC_BSD | (2 << 13);
- __gem_execbuf(fd, &execbuf);
- }
-
- gem_sync(fd, obj.handle);
- gem_close(fd, obj.handle);
-
- igt_drop_caches_set(fd, DROP_RETIRE | DROP_FREED);
+ igt_drop_caches_set(fd, DROP_ACTIVE | DROP_RETIRE | DROP_FREED);
}
/**
--
2.15.0.rc0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2017-10-12 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 20:54 Chris Wilson [this message]
2017-10-12 21:42 ` ✗ Fi.CI.BAT: failure for lib: Ask the kernel to quiesce the GPU Patchwork
2017-10-19 15:26 [PATCH igt] " Chris Wilson
2017-11-14 21:54 Chris Wilson
2017-12-08 19:26 [igt CI] " Chris Wilson
2017-12-11 11:38 ` [PATCH igt] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012205442.27049-1-chris@chris-wilson.co.uk \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.