From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 7/9] drm/i915: Switch fbc over to for_each_new_intel_plane_in_state() Date: Fri, 13 Oct 2017 13:38:32 +0300 Message-ID: <20171013103832.GW10981@intel.com> References: <20171011160455.1874-1-ville.syrjala@linux.intel.com> <20171011160455.1874-8-ville.syrjala@linux.intel.com> <20171012192107.zxihvpl3elbkouxk@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C04916E095 for ; Fri, 13 Oct 2017 10:38:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171012192107.zxihvpl3elbkouxk@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTIsIDIwMTcgYXQgMDk6MjE6MDdQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBXZWQsIE9jdCAxMSwgMjAxNyBhdCAwNzowNDo1M1BNICswMzAwLCBWaWxsZSBT eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gU3RvcCB1c2luZyB0aGUgb2xkIGZvcl9lYWNoX2ludGVs X3BsYW5lX2luX3N0YXRlKCkgdHlwZSBpdGVyYXRpb24KPiA+IG1hY3JvIGFuZCByZXBsYWNlIGl0 IHdpdGggZm9yX2VhY2hfbmV3X2ludGVsX3BsYW5lX2luX3N0YXRlKCkuCj4gPiBBbmQgc2ltaWxh cmx5IHJlcGxhY2UgZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZSgpIHdpdGgKPiA+ IGludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoKS4gU3dpdGNoIG92ZXIgdG8gaW50ZWxf IHR5cGVzCj4gPiBhcyB3ZWxsIHRvIG1ha2UgdGhlIGNvZGUgbGVzcyBjbHV0dGVyZWQuCj4gPiAK PiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmggICAgICB8ICA3ICsrKy0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgfCAgMiArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8 ICAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgICAgIHwgMjMgKysr KysrKysrKy0tLS0tLS0tLS0tLS0KPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMo KyksIDE5IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+IGlu ZGV4IGRmMTIwYTM4YWU0Mi4uOWM0NzM1ZGEyMTY5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ID4gQEAgLTU2MSwxMyArNTYxLDEzIEBAIHN0cnVjdCBpOTE1X2hvdHBsdWcgewo+ ID4gIAlmb3JfZWFjaF9wb3dlcl93ZWxsX3JldihfX2Rldl9wcml2LCBfX3Bvd2VyX3dlbGwpCQkg ICAgICAgIFwKPiA+ICAJCWZvcl9lYWNoX2lmICgoX19wb3dlcl93ZWxsKS0+ZG9tYWlucyAmIChf X2RvbWFpbl9tYXNrKSkKPiA+ICAKPiA+IC0jZGVmaW5lIGZvcl9lYWNoX2ludGVsX3BsYW5lX2lu X3N0YXRlKF9fc3RhdGUsIHBsYW5lLCBwbGFuZV9zdGF0ZSwgX19pKSBcCj4gPiArI2RlZmluZSBm b3JfZWFjaF9uZXdfaW50ZWxfcGxhbmVfaW5fc3RhdGUoX19zdGF0ZSwgcGxhbmUsIG5ld19wbGFu ZV9zdGF0ZSwgX19pKSBcCj4gPiAgCWZvciAoKF9faSkgPSAwOyBcCj4gPiAgCSAgICAgKF9faSkg PCAoX19zdGF0ZSktPmJhc2UuZGV2LT5tb2RlX2NvbmZpZy5udW1fdG90YWxfcGxhbmUgJiYgXAo+ ID4gIAkJICAgICAoKHBsYW5lKSA9IHRvX2ludGVsX3BsYW5lKChfX3N0YXRlKS0+YmFzZS5wbGFu ZXNbX19pXS5wdHIpLCBcCj4gPiAtCQkgICAgICAocGxhbmVfc3RhdGUpID0gdG9faW50ZWxfcGxh bmVfc3RhdGUoKF9fc3RhdGUpLT5iYXNlLnBsYW5lc1tfX2ldLnN0YXRlKSwgMSk7IFwKPiA+ICsJ CSAgICAgIChuZXdfcGxhbmVfc3RhdGUpID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoKF9fc3RhdGUp LT5iYXNlLnBsYW5lc1tfX2ldLm5ld19zdGF0ZSksIDEpOyBcCj4gPiAgCSAgICAgKF9faSkrKykg XAo+ID4gLQkJZm9yX2VhY2hfaWYgKHBsYW5lX3N0YXRlKQo+ID4gKwkJZm9yX2VhY2hfaWYgKHBs YW5lKQo+ID4gIAo+ID4gICNkZWZpbmUgZm9yX2VhY2hfbmV3X2ludGVsX2NydGNfaW5fc3RhdGUo X19zdGF0ZSwgY3J0YywgbmV3X2NydGNfc3RhdGUsIF9faSkgXAo+ID4gIAlmb3IgKChfX2kpID0g MDsgXAo+ID4gQEAgLTU3Nyw3ICs1NzcsNiBAQCBzdHJ1Y3QgaTkxNV9ob3RwbHVnIHsKPiA+ICAJ ICAgICAoX19pKSsrKSBcCj4gPiAgCQlmb3JfZWFjaF9pZiAoY3J0YykKPiAKPiBXb3VsZCBiZSBu aWNlIHRvIGNvLWV2b2x2ZSBvdXIgdmVyc2lvbnMgb2YgdGhlc2UgYWxvbmcgdGhlIGxpbmVzIG9m Cj4gCj4gY29tbWl0IDMzMTQ5NGViNTEwMDJkMGVlOTk0MTRlMzkxOGUwNmQ1ZTlhMzk2MmQKPiBB dXRob3I6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5j b20+Cj4gRGF0ZTogICBXZWQgU2VwIDI3IDEwOjM1OjMyIDIwMTcgKzAyMDAKPiAKPiAgICAgZHJt L2F0b21pYzogTWFrZSBhdG9taWMgaXRlcmF0b3JzIGxlc3Mgc3VycHJpc2luZwoKSW5kZWVkLiBU aGUgc2FtZSBpZGVhIHBvcHBlZCBpbnRvIG15IGhlYWQgd2hlbiBJIHNhdyBNYWFydGVuJ3MgcGF0 Y2gsCmJ1dCBhcHBhcmVudGx5IEkgZm9yZ290IHRvIHJlcGx5IHRvIHRoZSBwYXRjaCB0byBwcm9w b3NlIGl0LgoKPiAKPiBPbiB0aGUgcGF0Y2ggaXRzZWxmOgo+IAo+IFJldmlld2VkLWJ5OiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IAo+ID4gIAo+ID4gLQo+ID4gICNk ZWZpbmUgZm9yX2VhY2hfb2xkbmV3X2ludGVsX3BsYW5lX2luX3N0YXRlKF9fc3RhdGUsIHBsYW5l LCBvbGRfcGxhbmVfc3RhdGUsIG5ld19wbGFuZV9zdGF0ZSwgX19pKSBcCj4gPiAgCWZvciAoKF9f aSkgPSAwOyBcCj4gPiAgCSAgICAgKF9faSkgPCAoX19zdGF0ZSktPmJhc2UuZGV2LT5tb2RlX2Nv bmZpZy5udW1fdG90YWxfcGxhbmUgJiYgXAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+ID4gaW5kZXggODJiZTIzNDJkMWM2Li5jY2RmZDkyMmZlNWIgMTAwNjQ0Cj4gPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTEyMDI1LDcgKzEyMDI1LDcgQEAg c3RhdGljIGludCBpbnRlbF9hdG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ ICAJaWYgKHJldCkKPiA+ICAJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiAtCWludGVsX2ZiY19jaG9v c2VfY3J0YyhkZXZfcHJpdiwgc3RhdGUpOwo+ID4gKwlpbnRlbF9mYmNfY2hvb3NlX2NydGMoZGV2 X3ByaXYsIGludGVsX3N0YXRlKTsKPiA+ICAJcmV0dXJuIGNhbGNfd2F0ZXJtYXJrX2RhdGEoc3Rh dGUpOwo+ID4gIH0KPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBpbmRleCAw ODMxODI2MDQ1M2IuLjA4NTJiMzM3MTJiMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+ID4gQEAgLTE2NDUsNyArMTY0NSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9m YmRldl9yZXN0b3JlX21vZGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAKPiA+ICAvKiBp bnRlbF9mYmMuYyAqLwo+ID4gIHZvaWQgaW50ZWxfZmJjX2Nob29zZV9jcnRjKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+IC0JCQkgICBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUpOwo+ID4gKwkJCSAgIHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlKTsK PiA+ICBib29sIGludGVsX2ZiY19pc19hY3RpdmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KTsKPiA+ICB2b2lkIGludGVsX2ZiY19wcmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjLAo+ID4gIAkJCSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+ID4gaW5kZXggOGUzYTA1NTA1ZjQ5Li4wYjQwYjg5 ZjhlMmIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiA+IEBAIC0xMDUxLDEx ICsxMDUxLDExIEBAIHZvaWQgaW50ZWxfZmJjX2ZsdXNoKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiA+ICAgKiBlbmFibGUgRkJDIGZvciB0aGUgY2hvc2VuIENSVEMuIElmIGl0 IGRvZXMsIGl0IHdpbGwgc2V0IGRldl9wcml2LT5mYmMuY3J0Yy4KPiA+ICAgKi8KPiA+ICB2b2lk IGludGVsX2ZiY19jaG9vc2VfY3J0YyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gPiAtCQkJICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gKwkJCSAgIHN0 cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gIHsKPiA+ICAJc3RydWN0IGludGVs X2ZiYyAqZmJjID0gJmRldl9wcml2LT5mYmM7Cj4gPiAtCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l Owo+ID4gLQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiA+ICsJc3RydWN0 IGludGVsX3BsYW5lICpwbGFuZTsKPiA+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpwbGFu ZV9zdGF0ZTsKPiA+ICAJYm9vbCBjcnRjX2Nob3NlbiA9IGZhbHNlOwo+ID4gIAlpbnQgaTsKPiA+ ICAKPiA+IEBAIC0xMDYzLDcgKzEwNjMsNyBAQCB2b2lkIGludGVsX2ZiY19jaG9vc2VfY3J0Yyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCj4gPiAgCS8qIERvZXMgdGhp cyBhdG9taWMgY29tbWl0IGludm9sdmUgdGhlIENSVEMgY3VycmVudGx5IHRpZWQgdG8gRkJDPyAq Lwo+ID4gIAlpZiAoZmJjLT5jcnRjICYmCj4gPiAtCSAgICAhZHJtX2F0b21pY19nZXRfZXhpc3Rp bmdfY3J0Y19zdGF0ZShzdGF0ZSwgJmZiYy0+Y3J0Yy0+YmFzZSkpCj4gPiArCSAgICAhaW50ZWxf YXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgZmJjLT5jcnRjKSkKPiA+ICAJCWdvdG8g b3V0Owo+ID4gIAo+ID4gIAlpZiAoIWludGVsX2ZiY19jYW5fZW5hYmxlKGRldl9wcml2KSkKPiA+ IEBAIC0xMDczLDEzICsxMDczLDExIEBAIHZvaWQgaW50ZWxfZmJjX2Nob29zZV9jcnRjKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJICogcGxhbmUuIFdlIGNvdWxkIGdv IGZvciBmYW5jaWVyIHNjaGVtZXMgc3VjaCBhcyBjaGVja2luZyB0aGUgcGxhbmUKPiA+ICAJICog c2l6ZSwgYnV0IHRoaXMgd291bGQganVzdCBhZmZlY3QgdGhlIGZldyBwbGF0Zm9ybXMgdGhhdCBk b24ndCB0aWUgRkJDCj4gPiAgCSAqIHRvIHBpcGUgb3IgcGxhbmUgQS4gKi8KPiA+IC0JZm9yX2Vh Y2hfbmV3X3BsYW5lX2luX3N0YXRlKHN0YXRlLCBwbGFuZSwgcGxhbmVfc3RhdGUsIGkpIHsKPiA+ IC0JCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfcGxhbmVfc3RhdGUgPQo+ID4gLQkJ CXRvX2ludGVsX3BsYW5lX3N0YXRlKHBsYW5lX3N0YXRlKTsKPiA+IC0JCXN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICppbnRlbF9jcnRjX3N0YXRlOwo+ID4gLQkJc3RydWN0IGludGVsX2NydGMgKmNy dGMgPSB0b19pbnRlbF9jcnRjKHBsYW5lX3N0YXRlLT5jcnRjKTsKPiA+ICsJZm9yX2VhY2hfbmV3 X2ludGVsX3BsYW5lX2luX3N0YXRlKHN0YXRlLCBwbGFuZSwgcGxhbmVfc3RhdGUsIGkpIHsKPiA+ ICsJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4gKwkJc3RydWN0IGlu dGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKHBsYW5lX3N0YXRlLT5iYXNlLmNydGMpOwo+ ID4gIAo+ID4gLQkJaWYgKCFpbnRlbF9wbGFuZV9zdGF0ZS0+YmFzZS52aXNpYmxlKQo+ID4gKwkJ aWYgKCFwbGFuZV9zdGF0ZS0+YmFzZS52aXNpYmxlKQo+ID4gIAkJCWNvbnRpbnVlOwo+ID4gIAo+ ID4gIAkJaWYgKGZiY19vbl9waXBlX2Ffb25seShkZXZfcHJpdikgJiYgY3J0Yy0+cGlwZSAhPSBQ SVBFX0EpCj4gPiBAQCAtMTA4OCwxMCArMTA4Niw5IEBAIHZvaWQgaW50ZWxfZmJjX2Nob29zZV9j cnRjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCWlmIChmYmNfb25f cGxhbmVfYV9vbmx5KGRldl9wcml2KSAmJiBjcnRjLT5wbGFuZSAhPSBQTEFORV9BKQo+ID4gIAkJ CWNvbnRpbnVlOwo+ID4gIAo+ID4gLQkJaW50ZWxfY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNf c3RhdGUoCj4gPiAtCQkJZHJtX2F0b21pY19nZXRfZXhpc3RpbmdfY3J0Y19zdGF0ZShzdGF0ZSwg JmNydGMtPmJhc2UpKTsKPiA+ICsJCWNydGNfc3RhdGUgPSBpbnRlbF9hdG9taWNfZ2V0X25ld19j cnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsKPiA+ICAKPiA+IC0JCWludGVsX2NydGNfc3RhdGUtPmVu YWJsZV9mYmMgPSB0cnVlOwo+ID4gKwkJY3J0Y19zdGF0ZS0+ZW5hYmxlX2ZiYyA9IHRydWU7Cj4g PiAgCQljcnRjX2Nob3NlbiA9IHRydWU7Cj4gPiAgCQlicmVhazsKPiA+ICAJfQo+ID4gLS0gCj4g PiAyLjEzLjYKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmls bGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK