From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757878AbdJMLEj (ORCPT ); Fri, 13 Oct 2017 07:04:39 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:49225 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbdJMLEi (ORCPT ); Fri, 13 Oct 2017 07:04:38 -0400 X-Google-Smtp-Source: AOwi7QBvnR1x6elIT++C8bNoCydjeCni3uvm/XE+MrP8YJ60IC/ZRzVhFswFnnVT4rvDq3tyuKhrlw== Date: Fri, 13 Oct 2017 13:04:43 +0200 From: Christoffer Dall To: Eric Auger Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, marc.zyngier@arm.com, peter.maydell@linaro.org, andre.przywara@arm.com, wanghaibin.wang@huawei.com, wu.wubin@huawei.com Subject: Re: [PATCH v2 01/10] KVM: arm/arm64: vgic-its: fix return value for restore Message-ID: <20171013110443.GF8927@cbox> References: <1506518920-18571-1-git-send-email-eric.auger@redhat.com> <1506518920-18571-2-git-send-email-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1506518920-18571-2-git-send-email-eric.auger@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 27, 2017 at 03:28:31PM +0200, Eric Auger wrote: > From: wanghaibin > > This patch fix the migrate restore tables failure. > > The same scene, at the destination, the restore tables > interface traversal guest memory, and check the dte/ite > is valid or not. If all dtes/ites are invalid, we will do > try next one, and the last it will take the 1 return value, > but currently, it be treated as error. That's not correct. > > This patch try to fix this problem. This commit message really needs work. > > Signed-off-by: wanghaibin > > --- > > need to CC stable > > v1 -> v2: > - if (ret > 0) ret = 0 > --- > virt/kvm/arm/vgic/vgic-its.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > index f51c1e1..fbbc97b 100644 > --- a/virt/kvm/arm/vgic/vgic-its.c > +++ b/virt/kvm/arm/vgic/vgic-its.c > @@ -2018,7 +2018,7 @@ static int vgic_its_restore_dte(struct vgic_its *its, u32 id, > return PTR_ERR(dev); > > ret = vgic_its_restore_itt(its, dev); > - if (ret) { > + if (ret < 0) { > vgic_its_free_device(its->dev->kvm, dev); > return ret; > } > @@ -2141,7 +2141,7 @@ static int vgic_its_restore_device_tables(struct vgic_its *its) > } > > if (ret > 0) > - ret = -EINVAL; > + ret = 0; > > return ret; > } > -- > 2.5.5 > And I agree with the idea of cleaning up the return values. I think it could be improved by always returning 0 on some success and -ERR on some error, and carry an additional return value is a parameter, indicating if the last entry was found, which can be omitted (be NULL) by callers who do not care. Otherwise: Acked-by: Christoffer Dall