From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: intel-sgx-kernel-dev@lists.01.org, platform-driver-x86@vger.kernel.org
Subject: Re: [intel-sgx-kernel-dev] [PATCH RFC v3 07/12] intel_sgx: driver for Intel Software Guard Extensions
Date: Fri, 13 Oct 2017 23:08:24 +0300 [thread overview]
Message-ID: <20171013200824.dnwal6prligflo74@linux.intel.com> (raw)
In-Reply-To: <20171013200253.ou5fvexlevjet7nj@linux.intel.com>
On Fri, Oct 13, 2017 at 11:02:53PM +0300, Jarkko Sakkinen wrote:
> On Fri, Oct 13, 2017 at 10:58:49PM +0300, Jarkko Sakkinen wrote:
> > On Tue, Oct 10, 2017 at 11:26:06AM -0700, Sean Christopherson wrote:
> > > On Tue, Oct 10, 2017 at 05:32:53PM +0300, Jarkko Sakkinen wrote:
> > > > diff --git a/drivers/platform/x86/intel_sgx/sgx_encl.c b/drivers/platform/x86/intel_sgx/sgx_encl.c
> > > > new file mode 100644
> > > > index 000000000000..aa0deed08cee
> > > > --- /dev/null
> > > > +++ b/drivers/platform/x86/intel_sgx/sgx_encl.c
> > > > @@ -0,0 +1,989 @@
> > > >
> > > > +/**
> > > > + * sgx_encl_find - find an enclave
> > > > + * @mm: mm struct of the current process
> > > > + * @addr: address in the ELRANGE
> > > > + * @created is the enclave already created?
> > > > + * @vma: the resulting VMA
> > > > + *
> > > > + * Finds an enclave identified by the given address. Gives back the VMA, that is
> > > > + * part of the enclave, located in that address.
> > > > + *
> > > > + * Return:
> > > > + * 0 on success,
> > > > + * -EINVAL if not found,
> > > > + */
> > > > +int sgx_encl_find(struct mm_struct *mm, unsigned long addr, bool created,
> > > > + struct vm_area_struct **vma)
> > > > +{
> > > > + struct vm_area_struct *result;
> > > > + struct sgx_encl *encl;
> > > > +
> > > > + result = find_vma(mm, addr);
> > > > + if (!result || result->vm_ops != &sgx_vm_ops || addr < result->vm_start)
> > > > + return -EINVAL;
> > > > +
> > > > + encl = result->vm_private_data;
> > > > + if (created) {
> > > > + if (!encl)
> > > > + return -EINVAL;
> > > > + } else {
> > > > + if (encl)
> > > > + return -EINVAL;
> > > > + }
> > >
> > > What about removing @created and returning -ENOENT (or -ENXIO?) if
> > > result->vm_private_data is NULL? Removing @created will eliminate
> > > any potential confusion for the common case of @created=true. For
> > > @created=false, which should be limited to sgx_encl_create, I think
> > > that explicitly checking for "ret != -ENOENT" is more intuitive
> > > than checking whether or not sgx_encl_find succeeded, e.g. I knew
> > > the intent of the check in sgx_encl_create ahead of time and I still
> > > had to walk through sgx_encl_find to verify the behavior.
> >
> > Would make sense. Thank you.
> >
> > /Jarkko
>
> And in the case of ioctls (sgx_encl_get()) it would probably make sense
> to deliver -ENOENT back to the user space instead of -EINVAL, wouldn't it?
>
> /Jarkko
Please ignore this response! :-)
/Jarkko
next prev parent reply other threads:[~2017-10-13 20:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 14:32 [PATCH RFC v3 00/12] Intel(R) SGX Driver Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 01/12] intel_sgx: updated MAINTAINERS Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 02/12] x86: add SGX definition to cpufeature Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 03/12] x86: define the feature control MSR's SGX enable bit Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 04/12] x86: define the feature control MSR's SGX launch control bit Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 05/12] x86: add SGX MSRs to msr-index.h Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 06/12] fs/pipe.c: export create_pipe_files() and replace_fd() Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 08/12] intel_sgx: ptrace() support Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 09/12] intel_sgx: driver documentation Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 10/12] intel_sgx: in-kernel launch enclave Jarkko Sakkinen
2017-11-08 20:07 ` [intel-sgx-kernel-dev] " Sean Christopherson
2017-11-14 14:22 ` Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 11/12] intel_sgx: glue code for in-kernel LE Jarkko Sakkinen
2017-10-10 14:32 ` [PATCH RFC v3 12/12] intel_sgx: update IA32_SGXLEPUBKEYHASH* MSRs Jarkko Sakkinen
[not found] ` <20171010143258.21623-8-jarkko.sakkinen@linux.intel.com>
2017-10-10 15:41 ` [intel-sgx-kernel-dev] [PATCH RFC v3 07/12] intel_sgx: driver for Intel Software Guard Extensions Sean Christopherson
2017-10-11 11:46 ` Jarkko Sakkinen
2017-10-11 15:56 ` Sean Christopherson
2017-10-10 18:26 ` Sean Christopherson
2017-10-13 19:58 ` Jarkko Sakkinen
2017-10-13 20:02 ` Jarkko Sakkinen
2017-10-13 20:08 ` Jarkko Sakkinen [this message]
2017-10-13 20:13 ` Jarkko Sakkinen
2017-10-12 16:48 ` Sean Christopherson
2017-10-13 19:16 ` Jarkko Sakkinen
2017-11-02 19:48 ` Sean Christopherson
2017-11-06 7:23 ` Jarkko Sakkinen
2017-11-02 20:10 ` Sean Christopherson
2017-11-06 11:08 ` Jarkko Sakkinen
2017-11-06 11:33 ` Jarkko Sakkinen
2017-11-06 14:56 ` Sean Christopherson
2017-11-08 6:25 ` Jarkko Sakkinen
2017-11-06 11:39 ` Jarkko Sakkinen
2017-11-06 14:54 ` Sean Christopherson
2017-11-07 18:43 ` Jarkko Sakkinen
2017-11-06 15:54 ` Dave Hansen
2017-11-07 18:47 ` Jarkko Sakkinen
2017-11-07 19:05 ` Dave Hansen
2017-11-14 19:33 ` Jarkko Sakkinen
2017-11-14 21:05 ` Jarkko Sakkinen
2017-11-14 21:12 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013200824.dnwal6prligflo74@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=intel-sgx-kernel-dev@lists.01.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.