From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754765AbdJPQNB (ORCPT ); Mon, 16 Oct 2017 12:13:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33630 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754469AbdJPQM6 (ORCPT ); Mon, 16 Oct 2017 12:12:58 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 3.18 18/19] USB: serial: console: fix use-after-free after failed setup Date: Mon, 16 Oct 2017 18:12:09 +0200 Message-Id: <20171016160922.941246165@linuxfoundation.org> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171016160922.020176454@linuxfoundation.org> References: <20171016160922.020176454@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit 299d7572e46f98534033a9e65973f13ad1ce9047 upstream. Make sure to reset the USB-console port pointer when console setup fails in order to avoid having the struct usb_serial be prematurely freed by the console code when the device is later disconnected. Fixes: 73e487fdb75f ("[PATCH] USB console: fix disconnection issues") Acked-by: Greg Kroah-Hartman Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/console.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/serial/console.c +++ b/drivers/usb/serial/console.c @@ -187,6 +187,7 @@ static int usb_console_setup(struct cons tty_kref_put(tty); reset_open_count: port->port.count = 0; + info->port = NULL; usb_autopm_put_interface(serial->interface); error_get_interface: usb_serial_put(serial);