From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932073AbdJPSfW (ORCPT ); Mon, 16 Oct 2017 14:35:22 -0400 Received: from mga01.intel.com ([192.55.52.88]:35506 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323AbdJPSfU (ORCPT ); Mon, 16 Oct 2017 14:35:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,387,1503385200"; d="scan'208";a="163765411" Date: Mon, 16 Oct 2017 21:35:12 +0300 From: Jarkko Sakkinen To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations Message-ID: <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171016183139.otyh3m5c5yurtmow@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 09:31:39PM +0300, Jarkko Sakkinen wrote: > On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 16 Oct 2017 19:12:34 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > > > Markus Elfring (4): > > Delete an error message for a failed memory allocation > > in tpm_ascii_bios_measurements_show() > > Delete an error message for a failed memory allocation in tpm_ibmvtpm_probe() > > Improve a size determination in nine functions > > Less checks in tpm_ibmvtpm_probe() after error detection > > > > drivers/char/tpm/st33zp24/i2c.c | 3 +-- > > drivers/char/tpm/st33zp24/spi.c | 3 +-- > > drivers/char/tpm/st33zp24/st33zp24.c | 3 +-- > > drivers/char/tpm/tpm1_eventlog.c | 5 +---- > > drivers/char/tpm/tpm_crb.c | 2 +- > > drivers/char/tpm/tpm_i2c_atmel.c | 2 +- > > drivers/char/tpm/tpm_i2c_nuvoton.c | 2 +- > > drivers/char/tpm/tpm_ibmvtpm.c | 23 +++++++++-------------- > > drivers/char/tpm/tpm_tis.c | 2 +- > > drivers/char/tpm/tpm_tis_spi.c | 3 +-- > > 10 files changed, 18 insertions(+), 30 deletions(-) > > > > -- > > 2.14.2 > > > > For some sparse errors I fixed a while ago I got review feedback that > one should explain what is wrong what the fix does and not tell tool > reported. And it really does make sense to me. > > Describing the tool that was used to find the issues fits to the cover > letter but not to the commits themselves. > > I think I recently accepted a small fix with a "tool generated commit > message" but I don't want to take it as a practice It was a minor > mistake from my side to accept such patch. A minor complaint: all commits are missing "Fixes:" tag. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Mon, 16 Oct 2017 18:35:12 +0000 Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations Message-Id: <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> List-Id: References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> In-Reply-To: <20171016183139.otyh3m5c5yurtmow@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org On Mon, Oct 16, 2017 at 09:31:39PM +0300, Jarkko Sakkinen wrote: > On Mon, Oct 16, 2017 at 07:30:13PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 16 Oct 2017 19:12:34 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > > > Markus Elfring (4): > > Delete an error message for a failed memory allocation > > in tpm_ascii_bios_measurements_show() > > Delete an error message for a failed memory allocation in tpm_ibmvtpm_probe() > > Improve a size determination in nine functions > > Less checks in tpm_ibmvtpm_probe() after error detection > > > > drivers/char/tpm/st33zp24/i2c.c | 3 +-- > > drivers/char/tpm/st33zp24/spi.c | 3 +-- > > drivers/char/tpm/st33zp24/st33zp24.c | 3 +-- > > drivers/char/tpm/tpm1_eventlog.c | 5 +---- > > drivers/char/tpm/tpm_crb.c | 2 +- > > drivers/char/tpm/tpm_i2c_atmel.c | 2 +- > > drivers/char/tpm/tpm_i2c_nuvoton.c | 2 +- > > drivers/char/tpm/tpm_ibmvtpm.c | 23 +++++++++-------------- > > drivers/char/tpm/tpm_tis.c | 2 +- > > drivers/char/tpm/tpm_tis_spi.c | 3 +-- > > 10 files changed, 18 insertions(+), 30 deletions(-) > > > > -- > > 2.14.2 > > > > For some sparse errors I fixed a while ago I got review feedback that > one should explain what is wrong what the fix does and not tell tool > reported. And it really does make sense to me. > > Describing the tool that was used to find the issues fits to the cover > letter but not to the commits themselves. > > I think I recently accepted a small fix with a "tool generated commit > message" but I don't want to take it as a practice It was a minor > mistake from my side to accept such patch. A minor complaint: all commits are missing "Fixes:" tag. /Jarkko