From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756396AbdJPQut (ORCPT ); Mon, 16 Oct 2017 12:50:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42448 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbdJPQur (ORCPT ); Mon, 16 Oct 2017 12:50:47 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E9BC6862A Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=mst@redhat.com Date: Mon, 16 Oct 2017 19:50:45 +0300 From: "Michael S. Tsirkin" To: Bart Van Assche Cc: "hch@lst.de" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "torvalds@linux-foundation.org" , "qla2xxx-upstream@qlogic.com" , "martin.petersen@oracle.com" , "jejb@linux.vnet.ibm.com" Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks Message-ID: <20171016193921-mutt-send-email-mst@kernel.org> References: <20171006172353.16758-1-bart.vanassche@wdc.com> <20171009162008-mutt-send-email-mst@kernel.org> <1507561661.2674.3.camel@wdc.com> <20171009204139-mutt-send-email-mst@kernel.org> <1507653494.2815.27.camel@wdc.com> <20171016160316-mutt-send-email-mst@kernel.org> <1508162253.2728.1.camel@wdc.com> <20171016181159-mutt-send-email-mst@kernel.org> <1508168209.2493.13.camel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1508168209.2493.13.camel@wdc.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 16 Oct 2017 16:50:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 03:36:50PM +0000, Bart Van Assche wrote: > On Mon, 2017-10-16 at 18:27 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 16, 2017 at 01:57:35PM +0000, Bart Van Assche wrote: > > > On Mon, 2017-10-16 at 16:34 +0300, Michael S. Tsirkin wrote: > > > > I don't see how it'll help make things better. OTOH if the specific > > > > drivers are tagged in the makefile, they can be gradually moved out to > > > > staging or something to help trigger action. > > > > > > Do you really want to move drivers like qla2xxx to staging? That driver is > > > important to multiple enterprise distro's. > > > > Frankly I'm surprised this one has sparse issues. > > Really e.g. drivers/scsi/qla2xxx/qla_nvme.h is new from June 2017. > > > > It's not some ancient piece of code that no one understands so > > we are afraid to touch it. > > Sorry if I wasn't clear enough but I wasn't referring to the qla2xxx NVMe > code. I was referring to the qla2xxx FC initiator code. I think that code > went upstream in January 2004. See also > https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/log/drivers/scsi/qla2xxx?ofs=100 > > Bart. Right but qla_nvme also triggers these warnings. That's the problem with disabling them tree-wide. To me it looks like the time we are spending arguing about work-arounds would be better spent just fixing the majority of the code. If a couple of places aren't clean and need more thought, that's not a big deal. -- MST