From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763583AbdJQSmX (ORCPT ); Tue, 17 Oct 2017 14:42:23 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:45233 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759770AbdJQSmV (ORCPT ); Tue, 17 Oct 2017 14:42:21 -0400 X-Google-Smtp-Source: ABhQp+SdAVrpGXeNcqYpYzpvXtkNs+XCdepkQRbstyzFqM3AB1vRD9LRsw0+860fUut6clHAdr56Nw== Date: Tue, 17 Oct 2017 20:42:18 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Mario Limonciello Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org, Andy Lutomirski , quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, Greg KH , Alan Cox Subject: Re: [PATCH v9 02/17] platform/x86: dell-wmi: increase severity of some failures Message-ID: <20171017184218.rhhon6swipfntn4s@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 17 October 2017 13:21:46 Mario Limonciello wrote: > There is a lot of error checking in place for the format of the WMI > descriptor buffer, but some of the potentially raised issues should > be considered critical failures. > > If the buffer size or header don't match, this is a good indication > that the buffer format changed in a way that the rest of the data > should not be relied upon. > > For the remaining data set vectors, continue to notate a warning > in undefined results, but as those are fields that the descriptor > intended to refer to other applications, don't fail if they're new > values. > > Signed-off-by: Mario Limonciello > Reviewed-by: Edward O'Callaghan Reviewed-by: Pali Rohár -- Pali Rohár pali.rohar@gmail.com