From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934701AbdJQUcu (ORCPT ); Tue, 17 Oct 2017 16:32:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33964 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934662AbdJQUcs (ORCPT ); Tue, 17 Oct 2017 16:32:48 -0400 From: Nayna Jain To: linux-integrity@vger.kernel.org Cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, patrickc@us.ibm.com, Nayna Jain Subject: [PATCH v4 0/4] additional TPM performance improvements Date: Tue, 17 Oct 2017 16:32:28 -0400 X-Mailer: git-send-email 2.13.3 X-TM-AS-MML: disable x-cbid: 17101720-0040-0000-0000-00000403C92D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17101720-0041-0000-0000-000020A615C8 Message-Id: <20171017203232.2262-1-nayna@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-10-17_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=5 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1710170289 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After further discussions with the TCG Device Driver working group (ddwg), the following changes were made: * Check for burstcount at least once to confirm the TPM is ready to accept the data. Similarly, query for the TPM Expect status as sanity check at the end. * Make the sleep for status check in the loop less than 5msec. * Make the sleep in the loop while querying for burstcount less than 5msec. Below is the list of patches along with the performance improvements seen with a TPM 1.2 with an 8 byte burstcount for 1000 extends: Patch |Improvement(time in sec) tpm: ignore burstcount to improve tpm_tis | ~41 - ~14 send() performance. tpm: reduce polling delay in tpm_tis_core | ~14 - ~9 tpm: modify tpm_msleep() function to have | ~9 - ~8 max range Changelog v4: * Include Jarkko's feedback on merging two patches reducing sleep time during polling to TPM. * Include Jarkko's feedback to clean up the burstcount change patch and add comment for new #define. Changelog v3: * Include Jarkko's feedback to move wait_for_tpm_stat() from tpm-interface.c to respective driver files tpm_tis_core.c and xen-tpmfront.c. * Remove use of module parameter ignore_burst_count and is now alwaysed ignored in tpm tis send() operation. * Reduce sleep() time during polling in wait_for_tpm_stat() from 5msec to 1msec for both recv() and send() operation. Version 2 of the patches had it only for send() operation. Changelog v2: * Add module parameter to handle ignoring of burst count during tpm tis send() operation. * Add improvements over sleep time to reduce delays. Nayna Jain (4): tpm: move wait_for_tpm_stat() to respective driver files tpm: ignore burstcount to improve tpm_tis send() performance tpm: reduce tpm polling delay in tpm_tis_core tpm: use tpm_msleep() value as max delay drivers/char/tpm/tpm-interface.c | 60 --------------------- drivers/char/tpm/tpm.h | 6 +-- drivers/char/tpm/tpm_tis_core.c | 110 +++++++++++++++++++++++++++++---------- drivers/char/tpm/xen-tpmfront.c | 60 +++++++++++++++++++++ 4 files changed, 144 insertions(+), 92 deletions(-) -- 2.13.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: nayna@linux.vnet.ibm.com (Nayna Jain) Date: Tue, 17 Oct 2017 16:32:28 -0400 Subject: [PATCH v4 0/4] additional TPM performance improvements Message-ID: <20171017203232.2262-1-nayna@linux.vnet.ibm.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org After further discussions with the TCG Device Driver working group (ddwg), the following changes were made: * Check for burstcount at least once to confirm the TPM is ready to accept the data. Similarly, query for the TPM Expect status as sanity check at the end. * Make the sleep for status check in the loop less than 5msec. * Make the sleep in the loop while querying for burstcount less than 5msec. Below is the list of patches along with the performance improvements seen with a TPM 1.2 with an 8 byte burstcount for 1000 extends: Patch |Improvement(time in sec) tpm: ignore burstcount to improve tpm_tis | ~41 - ~14 send() performance. tpm: reduce polling delay in tpm_tis_core | ~14 - ~9 tpm: modify tpm_msleep() function to have | ~9 - ~8 max range Changelog v4: * Include Jarkko's feedback on merging two patches reducing sleep time during polling to TPM. * Include Jarkko's feedback to clean up the burstcount change patch and add comment for new #define. Changelog v3: * Include Jarkko's feedback to move wait_for_tpm_stat() from tpm-interface.c to respective driver files tpm_tis_core.c and xen-tpmfront.c. * Remove use of module parameter ignore_burst_count and is now alwaysed ignored in tpm tis send() operation. * Reduce sleep() time during polling in wait_for_tpm_stat() from 5msec to 1msec for both recv() and send() operation. Version 2 of the patches had it only for send() operation. Changelog v2: * Add module parameter to handle ignoring of burst count during tpm tis send() operation. * Add improvements over sleep time to reduce delays. Nayna Jain (4): tpm: move wait_for_tpm_stat() to respective driver files tpm: ignore burstcount to improve tpm_tis send() performance tpm: reduce tpm polling delay in tpm_tis_core tpm: use tpm_msleep() value as max delay drivers/char/tpm/tpm-interface.c | 60 --------------------- drivers/char/tpm/tpm.h | 6 +-- drivers/char/tpm/tpm_tis_core.c | 110 +++++++++++++++++++++++++++++---------- drivers/char/tpm/xen-tpmfront.c | 60 +++++++++++++++++++++ 4 files changed, 144 insertions(+), 92 deletions(-) -- 2.13.3 -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html