From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: tim@xen.org, kevin.tian@intel.com, sstabellini@kernel.org,
wei.liu2@citrix.com, konrad.wilk@oracle.com,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
jbeulich@suse.com, Chao Gao <chao.gao@intel.com>
Subject: Re: [PATCH V3 4/29] tools/libacpi: Add DMA remapping reporting (DMAR) ACPI table structures
Date: Wed, 18 Oct 2017 15:36:05 +0100 [thread overview]
Message-ID: <20171018143605.v2hrmdlahm2ojv4y@dhcp-3-128.uk.xensource.com> (raw)
In-Reply-To: <1506049330-11196-5-git-send-email-tianyu.lan@intel.com>
On Thu, Sep 21, 2017 at 11:01:45PM -0400, Lan Tianyu wrote:
> From: Chao Gao <chao.gao@intel.com>
>
> Add dmar table structure according Chapter 8 "BIOS Considerations" of
> VTd spec Rev. 2.4.
>
> VTd spec:http://www.intel.com/content/dam/www/public/us/en/documents/product-specifications/vt-directed-io-spec.pdf
>
> Signed-off-by: Chao Gao <chao.gao@intel.com>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> ---
> tools/libacpi/acpi2_0.h | 61 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h
> index 2619ba3..758a823 100644
> --- a/tools/libacpi/acpi2_0.h
> +++ b/tools/libacpi/acpi2_0.h
> @@ -422,6 +422,65 @@ struct acpi_20_slit {
> };
>
> /*
> + * DMA Remapping Table header definition (DMAR)
> + */
> +
> +/*
> + * DMAR Flags.
> + */
> +#define ACPI_DMAR_INTR_REMAP (1 << 0)
> +#define ACPI_DMAR_X2APIC_OPT_OUT (1 << 1)
> +
> +struct acpi_dmar {
> + struct acpi_header header;
> + uint8_t host_address_width;
> + uint8_t flags;
> + uint8_t reserved[10];
> +};
> +
> +/*
> + * Device Scope Types
> + */
> +#define ACPI_DMAR_DEVICE_SCOPE_PCI_ENDPOINT 0x01
> +#define ACPI_DMAR_DEVICE_SCOPE_PCI_SUB_HIERARACHY 0x01
^0x02
> +#define ACPI_DMAR_DEVICE_SCOPE_IOAPIC 0x03
> +#define ACPI_DMAR_DEVICE_SCOPE_HPET 0x04
> +#define ACPI_DMAR_DEVICE_SCOPE_ACPI_NAMESPACE_DEVICE 0x05
Maybe you could try to reduce the length of the defines?
> +
> +struct dmar_device_scope {
> + uint8_t type;
> + uint8_t length;
> + uint8_t reserved[2];
> + uint8_t enumeration_id;
> + uint8_t bus;
> + uint16_t path[0];
> +};
> +
> +/*
> + * DMA Remapping Hardware Unit Types
> + */
> +#define ACPI_DMAR_TYPE_HARDWARE_UNIT 0x00
> +#define ACPI_DMAR_TYPE_RESERVED_MEMORY 0x01
> +#define ACPI_DMAR_TYPE_ATSR 0x02
> +#define ACPI_DMAR_TYPE_HARDWARE_AFFINITY 0x03
> +#define ACPI_DMAR_TYPE_ANDD 0x04
I think you either use acronyms for all of them (like ATSR and ANDD)
or not. But mixing acronyms with full names is confusing.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-18 14:36 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 3:01 [PATCH V3 00/29] Lan Tianyu
2017-09-22 3:01 ` [PATCH V3 1/29] Xen/doc: Add Xen virtual IOMMU doc Lan Tianyu
2017-10-18 13:26 ` Roger Pau Monné
2017-10-19 2:26 ` Lan Tianyu
2017-10-19 8:49 ` Roger Pau Monné
2017-10-19 11:28 ` Jan Beulich
2017-10-24 7:16 ` Lan Tianyu
2017-09-22 3:01 ` [PATCH V3 2/29] VIOMMU: Add vIOMMU helper functions to create, destroy vIOMMU instance Lan Tianyu
2017-10-18 14:05 ` Roger Pau Monné
2017-10-19 6:31 ` Lan Tianyu
2017-10-19 8:47 ` Roger Pau Monné
2017-10-25 1:43 ` Lan Tianyu
2017-10-30 1:41 ` Lan Tianyu
2017-10-30 9:54 ` Roger Pau Monné
2017-10-30 1:51 ` Lan Tianyu
2017-11-06 8:19 ` Jan Beulich
2017-09-22 3:01 ` [PATCH V3 3/29] DOMCTL: Introduce new DOMCTL commands for vIOMMU support Lan Tianyu
2017-10-18 14:18 ` Roger Pau Monné
2017-10-19 6:41 ` Lan Tianyu
2017-09-22 3:01 ` [PATCH V3 4/29] tools/libacpi: Add DMA remapping reporting (DMAR) ACPI table structures Lan Tianyu
2017-10-18 14:36 ` Roger Pau Monné [this message]
2017-10-19 6:46 ` Lan Tianyu
2017-09-22 3:01 ` [PATCH V3 5/29] tools/libacpi: Add new fields in acpi_config for DMAR table Lan Tianyu
2017-10-18 15:12 ` Roger Pau Monné
2017-10-19 8:09 ` Lan Tianyu
2017-10-19 8:40 ` Roger Pau Monné
2017-10-25 6:06 ` Lan Tianyu
2017-10-19 11:31 ` Jan Beulich
2017-09-22 3:01 ` [PATCH V3 6/29] tools/libxl: Add a user configurable parameter to control vIOMMU attributes Lan Tianyu
2017-10-19 9:49 ` Roger Pau Monné
2017-10-20 1:36 ` Chao Gao
2017-09-22 3:01 ` [PATCH V3 7/29] tools/libxl: build DMAR table for a guest with one virtual VTD Lan Tianyu
2017-10-19 10:00 ` Roger Pau Monné
2017-10-20 1:44 ` Chao Gao
2017-09-22 3:01 ` [PATCH V3 8/29] tools/libxl: create vIOMMU during domain construction Lan Tianyu
2017-10-19 10:13 ` Roger Pau Monné
2017-10-26 12:05 ` Wei Liu
2017-10-27 1:58 ` Lan Tianyu
2017-09-22 3:01 ` [PATCH V3 9/29] tools/libxc: Add viommu operations in libxc Lan Tianyu
2017-10-19 10:17 ` Roger Pau Monné
2017-09-22 3:01 ` [PATCH V3 10/29] vtd: add and align register definitions Lan Tianyu
2017-10-19 10:21 ` Roger Pau Monné
2017-10-20 1:47 ` Chao Gao
2017-09-22 3:01 ` [PATCH V3 11/29] x86/hvm: Introduce a emulated VTD for HVM Lan Tianyu
2017-10-19 11:20 ` Roger Pau Monné
2017-10-20 2:46 ` Chao Gao
2017-10-20 6:56 ` Jan Beulich
2017-10-20 6:12 ` Chao Gao
2017-10-20 8:37 ` Lan Tianyu
2017-09-22 3:01 ` [PATCH V3 12/29] x86/vvtd: Add MMIO handler for VVTD Lan Tianyu
2017-10-19 11:34 ` Roger Pau Monné
2017-10-20 2:58 ` Chao Gao
2017-10-20 9:51 ` Roger Pau Monné
2017-09-22 3:01 ` [PATCH V3 13/29] x86/vvtd: Set Interrupt Remapping Table Pointer through GCMD Lan Tianyu
2017-10-19 11:56 ` Roger Pau Monné
2017-10-20 4:08 ` Chao Gao
2017-10-20 6:57 ` Jan Beulich
2017-09-22 3:01 ` [PATCH V3 14/29] x86/vvtd: Enable Interrupt Remapping " Lan Tianyu
2017-10-19 13:42 ` Roger Pau Monné
2017-09-22 3:01 ` [PATCH V3 15/29] x86/vvtd: Process interrupt remapping request Lan Tianyu
2017-10-19 14:26 ` Roger Pau Monné
2017-10-20 5:16 ` Chao Gao
2017-10-20 10:01 ` Roger Pau Monné
2017-10-23 6:44 ` Chao Gao
2017-09-22 3:01 ` [PATCH V3 16/29] x86/vvtd: decode interrupt attribute from IRTE Lan Tianyu
2017-10-19 14:39 ` Roger Pau Monné
2017-10-20 5:22 ` Chao Gao
2017-09-22 3:01 ` [PATCH V3 17/29] x86/vvtd: add a helper function to decide the interrupt format Lan Tianyu
2017-10-19 14:43 ` Roger Pau Monné
2017-09-22 3:01 ` [PATCH V3 18/29] VIOMMU: Add irq request callback to deal with irq remapping Lan Tianyu
2017-10-19 15:00 ` Roger Pau Monné
2017-09-22 3:02 ` [PATCH V3 19/29] x86/vioapic: Hook interrupt delivery of vIOAPIC Lan Tianyu
2017-10-19 15:37 ` Roger Pau Monné
2017-09-22 3:02 ` [PATCH V3 20/29] VIOMMU: Add get irq info callback to convert irq remapping request Lan Tianyu
2017-10-19 15:42 ` Roger Pau Monné
2017-10-25 7:30 ` Lan Tianyu
2017-10-25 7:43 ` Roger Pau Monné
2017-10-25 7:38 ` Lan Tianyu
2017-09-22 3:02 ` [PATCH V3 21/29] VIOMMU: Introduce callback of checking irq remapping mode Lan Tianyu
2017-10-19 15:43 ` Roger Pau Monné
2017-09-22 3:02 ` [PATCH V3 22/29] x86/vioapic: extend vioapic_get_vector() to support remapping format RTE Lan Tianyu
2017-10-19 15:49 ` Roger Pau Monné
2017-10-19 15:56 ` Jan Beulich
2017-10-20 1:04 ` Chao Gao
2017-09-22 3:02 ` [PATCH V3 23/29] passthrough: move some fields of hvm_gmsi_info to a sub-structure Lan Tianyu
2017-09-22 3:02 ` [PATCH V3 24/29] tools/libxc: Add a new interface to bind remapping format msi with pirq Lan Tianyu
2017-10-19 16:03 ` Roger Pau Monné
2017-10-20 5:39 ` Chao Gao
2017-09-22 3:02 ` [PATCH V3 25/29] x86/vmsi: Hook delivering remapping format msi to guest Lan Tianyu
2017-10-19 16:07 ` Roger Pau Monné
2017-10-20 6:48 ` Jan Beulich
2017-09-22 3:02 ` [PATCH V3 26/29] x86/vvtd: Handle interrupt translation faults Lan Tianyu
2017-10-19 16:31 ` Roger Pau Monné
2017-10-20 5:54 ` Chao Gao
2017-10-20 10:08 ` Roger Pau Monné
2017-10-20 14:20 ` Jan Beulich
2017-09-22 3:02 ` [PATCH V3 27/29] x86/vvtd: Enable Queued Invalidation through GCMD Lan Tianyu
2017-10-20 10:30 ` Roger Pau Monné
2017-09-22 3:02 ` [PATCH V3 28/29] x86/vvtd: Add queued invalidation (QI) support Lan Tianyu
2017-10-20 11:20 ` Roger Pau Monné
2017-10-23 7:50 ` Chao Gao
2017-10-23 8:57 ` Roger Pau Monné
2017-10-23 8:52 ` Chao Gao
2017-10-23 23:26 ` Tian, Kevin
2017-09-22 3:02 ` [PATCH V3 29/29] x86/vvtd: save and restore emulated VT-d Lan Tianyu
2017-10-20 11:25 ` Roger Pau Monné
2017-10-20 11:36 ` [PATCH V3 00/29] Roger Pau Monné
2017-10-23 1:23 ` Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018143605.v2hrmdlahm2ojv4y@dhcp-3-128.uk.xensource.com \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.gao@intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tianyu.lan@intel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.