From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbdJRPEu (ORCPT ); Wed, 18 Oct 2017 11:04:50 -0400 Received: from mga07.intel.com ([134.134.136.100]:63457 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbdJRPEs (ORCPT ); Wed, 18 Oct 2017 11:04:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,397,1503385200"; d="scan'208";a="164078946" Date: Wed, 18 Oct 2017 18:04:36 +0300 From: Jarkko Sakkinen To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations Message-ID: <20171018150436.j2uhzxsu4ebjoz3c@linux.intel.com> References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <2e5e24b4-ea4d-e43b-22b2-e6b65e7203d2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e5e24b4-ea4d-e43b-22b2-e6b65e7203d2@users.sourceforge.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 10:44:18PM +0200, SF Markus Elfring wrote: > > A minor complaint: all commits are missing "Fixes:" tag. > > * Do you require it to be added to the commit messages? I don't require it. It's part of the development process: https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html > * Would you like to get a finer patch granularity then? I don't understand what you are asking. > * Do you find any more information missing? > > Regards, > Markus I think I already answered to this in my earlier responses (commit messages). I probably won't take "sizeof(*foo)" type of change even if it is a recommended style if that is the only useful thing that the commit does. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Wed, 18 Oct 2017 15:04:36 +0000 Subject: Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations Message-Id: <20171018150436.j2uhzxsu4ebjoz3c@linux.intel.com> List-Id: References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <20171016183139.otyh3m5c5yurtmow@linux.intel.com> <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com> <2e5e24b4-ea4d-e43b-22b2-e6b65e7203d2@users.sourceforge.net> In-Reply-To: <2e5e24b4-ea4d-e43b-22b2-e6b65e7203d2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger , LKML , kernel-janitors@vger.kernel.org On Mon, Oct 16, 2017 at 10:44:18PM +0200, SF Markus Elfring wrote: > > A minor complaint: all commits are missing "Fixes:" tag. > > * Do you require it to be added to the commit messages? I don't require it. It's part of the development process: https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html > * Would you like to get a finer patch granularity then? I don't understand what you are asking. > * Do you find any more information missing? > > Regards, > Markus I think I already answered to this in my earlier responses (commit messages). I probably won't take "sizeof(*foo)" type of change even if it is a recommended style if that is the only useful thing that the commit does. /Jarkko