From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbdJRRTI (ORCPT ); Wed, 18 Oct 2017 13:19:08 -0400 Received: from mga06.intel.com ([134.134.136.31]:50557 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdJRRTG (ORCPT ); Wed, 18 Oct 2017 13:19:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,397,1503385200"; d="scan'208";a="1232288577" Date: Wed, 18 Oct 2017 20:18:58 +0300 From: Jarkko Sakkinen To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger Subject: Re: char/tpm: Improve a size determination in nine functions Message-ID: <20171018171858.3lcfr2kcp53fngwv@linux.intel.com> References: <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> <20171018155946.e7ga7jyex6eia252@linux.intel.com> <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 06:43:10PM +0200, SF Markus Elfring wrote: > > Commit message should just describe in plain text what you are doing > > Did other contributors find the wording “Replace …” > > > > and why. > > and “… a bit safer according to the Linux coding style convention.” > sufficient often enough already? > > Which description would you find more appropriate for this change pattern? > > Regards, > Markus For 1/4 and 2/4: explain why the message can be omitted. Remove sentence about Coccinelle. That's all. 3/4: definitive NAK, too much noise compared to value. 4/4: this a good commit message. Requires a Tested-by before can be accepted, which I'm not able to give. Hope this helps. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Wed, 18 Oct 2017 17:18:58 +0000 Subject: Re: char/tpm: Improve a size determination in nine functions Message-Id: <20171018171858.3lcfr2kcp53fngwv@linux.intel.com> List-Id: References: <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> <20171018155946.e7ga7jyex6eia252@linux.intel.com> <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> In-Reply-To: <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger On Wed, Oct 18, 2017 at 06:43:10PM +0200, SF Markus Elfring wrote: > > Commit message should just describe in plain text what you are doing > > Did other contributors find the wording “Replace …” > > > > and why. > > and “… a bit safer according to the Linux coding style convention.” > sufficient often enough already? > > Which description would you find more appropriate for this change pattern? > > Regards, > Markus For 1/4 and 2/4: explain why the message can be omitted. Remove sentence about Coccinelle. That's all. 3/4: definitive NAK, too much noise compared to value. 4/4: this a good commit message. Requires a Tested-by before can be accepted, which I'm not able to give. Hope this helps. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:50557 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdJRRTG (ORCPT ); Wed, 18 Oct 2017 13:19:06 -0400 Date: Wed, 18 Oct 2017 20:18:58 +0300 From: Jarkko Sakkinen To: SF Markus Elfring Cc: linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , Peter =?iso-8859-1?Q?H=FCwe?= , Stefan Berger Subject: Re: char/tpm: Improve a size determination in nine functions Message-ID: <20171018171858.3lcfr2kcp53fngwv@linux.intel.com> References: <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> <20171018155946.e7ga7jyex6eia252@linux.intel.com> <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Wed, Oct 18, 2017 at 06:43:10PM +0200, SF Markus Elfring wrote: > > Commit message should just describe in plain text what you are doing > > Did other contributors find the wording "Replace ..." > > > > and why. > > and "... a bit safer according to the Linux coding style convention." > sufficient often enough already? > > Which description would you find more appropriate for this change pattern? > > Regards, > Markus For 1/4 and 2/4: explain why the message can be omitted. Remove sentence about Coccinelle. That's all. 3/4: definitive NAK, too much noise compared to value. 4/4: this a good commit message. Requires a Tested-by before can be accepted, which I'm not able to give. Hope this helps. /Jarkko