From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] powertop: needs autoreconf
Date: Wed, 18 Oct 2017 22:33:39 +0300 [thread overview]
Message-ID: <20171018193339.2t2asjcmkdjdzzsw@tarshish> (raw)
In-Reply-To: <3d9c7e58-2980-e6f6-b23c-d85cff470769@gmail.com>
Hi Romain,
On Wed, Oct 18, 2017 at 08:58:55PM +0200, Romain Naour wrote:
> Le 18/10/2017 ? 20:03, Baruch Siach a ?crit?:
> > Commit 01048deab60 (package/powertop: bump to version 2.9) removed
> > autoreconf even though the remaining patch touches Makefile.am. Fix
> > this.
>
> Indeed...
> I don't recall what happened, probably I had the intend to remove all patches
> with the version bump but I finally re-added
> 0001-dont-force-stack-smashing-protection.patch.
>
> The issue appear now following the automake bump 1.15.1.
>
> > Fixes:
> > http://autobuild.buildroot.net/results/3bf/3bf8daee559e2978f8602c56397afda771299032/
> > http://autobuild.buildroot.net/results/f9b/f9b4f113a333107a972fa51bd0347eeb0d52496f/
> > http://autobuild.buildroot.net/results/067/0675826888b6f89e76291c7835839344300ca9f5/
> >
> > Cc: Romain Naour <romain.naour@gmail.com>
> > Cc: Steven Noonan <steven@uplinklabs.net>
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > package/powertop/powertop.mk | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/package/powertop/powertop.mk b/package/powertop/powertop.mk
> > index ce7a11875894..7c9c7ccc3f41 100644
> > --- a/package/powertop/powertop.mk
> > +++ b/package/powertop/powertop.mk
> > @@ -12,6 +12,8 @@ POWERTOP_DEPENDENCIES = pciutils ncurses libnl host-pkgconf \
> > POWERTOP_LICENSE = GPL-2.0
> > POWERTOP_LICENSE_FILES = COPYING
> > POWERTOP_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
> > +# Patching Makefile.am
>
> Maybe you can name the patch here
> # 0001-dont-force-stack-smashing-protection.patch
>
> > +POWERTOP_AUTORECONF = YES
>
> Gettextize was needed with powertop 2.27, can you check if it's still needed ?
The build succeeds here without gettextize. The same config fails without the
patch with the same error as the autobuilder.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2017-10-18 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 18:03 [Buildroot] [PATCH] powertop: needs autoreconf Baruch Siach
2017-10-18 18:58 ` Romain Naour
2017-10-18 19:33 ` Baruch Siach [this message]
2017-10-18 20:57 ` Romain Naour
2017-10-18 20:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018193339.2t2asjcmkdjdzzsw@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.